From: Kiran K <kiran.k@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: Kiran K <kiran.k@intel.com>
Subject: [PATCH v10 06/10] Bluetooth: Allow setting of codec for HFP offload usecase
Date: Wed, 30 Jun 2021 13:38:03 +0530 [thread overview]
Message-ID: <20210630080807.12600-6-kiran.k@intel.com> (raw)
In-Reply-To: <20210630080807.12600-1-kiran.k@intel.com>
For HFP offload usecase, controller needs to be configured
with codec data and capabilities. This patch uses Bluetooth
SIG defined command HCI_CONFIGURE_DATA_PATH to specify vendor
specific data and allows userspace modules to set the codec
via setsockopt systemcall.
Signed-off-by: Kiran K <kiran.k@intel.com>
Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
---
* changes in v10:
- patch refactor - having callback definition and usage in the same patch
include/net/bluetooth/bluetooth.h | 2 +
include/net/bluetooth/hci.h | 8 ++
include/net/bluetooth/hci_core.h | 3 +
net/bluetooth/sco.c | 123 ++++++++++++++++++++++++++++++
4 files changed, 136 insertions(+)
diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 1840756958ce..0e8802d09068 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -173,6 +173,8 @@ struct bt_codecs {
struct bt_codec codecs[];
} __packed;
+#define CODING_FORMAT_CVSD 0x02
+
__printf(1, 2)
void bt_info(const char *fmt, ...);
__printf(1, 2)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 5e4306a46324..ae384b7bf000 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -1250,6 +1250,14 @@ struct hci_rp_read_local_oob_ext_data {
__u8 rand256[16];
} __packed;
+#define HCI_CONFIGURE_DATA_PATH 0x0c83
+struct hci_op_configure_data_path {
+ __u8 direction;
+ __u8 data_path_id;
+ __u8 vnd_len;
+ __u8 vnd_data[];
+} __packed;
+
#define HCI_OP_READ_LOCAL_VERSION 0x1001
struct hci_rp_read_local_version {
__u8 status;
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index 00c97e2ce1fd..ebf42a3ac6cd 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -623,6 +623,9 @@ struct hci_dev {
bool (*prevent_wake)(struct hci_dev *hdev);
#if IS_ENABLED(CONFIG_BT_OFFLOAD_CODECS)
int (*get_data_path_id)(struct hci_dev *hdev, __u8 *data_path);
+ int (*get_codec_config_data)(struct hci_dev *hdev, __u8 type,
+ struct bt_codec *codec, __u8 *vnd_len,
+ __u8 **vnd_data);
#endif
};
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index ddf9b6bd9ca3..4b6ee0b302d7 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -67,6 +67,7 @@ struct sco_pinfo {
__u32 flags;
__u16 setting;
__u8 cmsg_mask;
+ struct bt_codec codec;
struct sco_conn *conn;
};
@@ -438,6 +439,7 @@ static void __sco_sock_close(struct sock *sk)
sock_set_flag(sk, SOCK_ZAPPED);
break;
}
+
}
/* Must be called on unlocked socket. */
@@ -499,6 +501,10 @@ static struct sock *sco_sock_alloc(struct net *net, struct socket *sock,
sk->sk_state = BT_OPEN;
sco_pi(sk)->setting = BT_VOICE_CVSD_16BIT;
+ sco_pi(sk)->codec.id = CODING_FORMAT_CVSD;
+ sco_pi(sk)->codec.cid = 0xffff;
+ sco_pi(sk)->codec.vid = 0xffff;
+ sco_pi(sk)->codec.data_path = 0x00;
timer_setup(&sk->sk_timer, sco_sock_timeout, 0);
@@ -802,6 +808,65 @@ static int sco_sock_recvmsg(struct socket *sock, struct msghdr *msg,
return bt_sock_recvmsg(sock, msg, len, flags);
}
+#if IS_ENABLED(CONFIG_BT_OFFLOAD_CODECS)
+static int sco_configure_data_path(struct hci_dev *hdev, struct bt_codec *codec)
+{
+ __u8 vnd_len, *vnd_data = NULL;
+ struct hci_op_configure_data_path *cmd = NULL;
+ struct sk_buff *skb;
+ int err;
+
+ err = hdev->get_codec_config_data(hdev, SCO_LINK, codec, &vnd_len,
+ &vnd_data);
+ if (err < 0)
+ goto error;
+
+ cmd = kzalloc(sizeof(*cmd) + vnd_len, GFP_KERNEL);
+ if (!cmd) {
+ err = -ENOMEM;
+ goto error;
+ }
+
+ err = hdev->get_data_path_id(hdev, &cmd->data_path_id);
+ if (err < 0)
+ goto error;
+
+ cmd->vnd_len = vnd_len;
+ memcpy(cmd->vnd_data, vnd_data, vnd_len);
+
+ cmd->direction = 0x00;
+ skb = __hci_cmd_sync(hdev, HCI_CONFIGURE_DATA_PATH,
+ sizeof(*cmd) + vnd_len,
+ cmd, HCI_INIT_TIMEOUT);
+
+ if (IS_ERR(skb)) {
+ err = PTR_ERR(skb);
+ bt_dev_err(hdev, "configure input data path failed (%ld)",
+ PTR_ERR(skb));
+ goto error;
+ }
+ kfree_skb(skb);
+
+ cmd->direction = 0x01;
+ skb = __hci_cmd_sync(hdev, HCI_CONFIGURE_DATA_PATH,
+ sizeof(*cmd) + vnd_len,
+ cmd, HCI_INIT_TIMEOUT);
+
+ if (IS_ERR(skb)) {
+ err = PTR_ERR(skb);
+ bt_dev_err(hdev, "configure output data path failed (%ld)",
+ PTR_ERR(skb));
+ goto error;
+ }
+ kfree_skb(skb);
+
+error:
+ kfree(vnd_data);
+ kfree(cmd);
+ return err;
+}
+#endif
+
static int sco_sock_setsockopt(struct socket *sock, int level, int optname,
sockptr_t optval, unsigned int optlen)
{
@@ -809,6 +874,11 @@ static int sco_sock_setsockopt(struct socket *sock, int level, int optname,
int len, err = 0;
struct bt_voice voice;
u32 opt;
+#if IS_ENABLED(CONFIG_BT_OFFLOAD_CODECS)
+ struct bt_codecs *codecs;
+ struct hci_dev *hdev;
+ __u8 buffer[255];
+#endif
BT_DBG("sk %p", sk);
@@ -870,6 +940,59 @@ static int sco_sock_setsockopt(struct socket *sock, int level, int optname,
sco_pi(sk)->cmsg_mask &= SCO_CMSG_PKT_STATUS;
break;
+#if IS_ENABLED(CONFIG_BT_OFFLOAD_CODECS)
+ case BT_CODEC:
+ if (sk->sk_state != BT_OPEN && sk->sk_state != BT_BOUND &&
+ sk->sk_state != BT_CONNECT2) {
+ err = -EINVAL;
+ break;
+ }
+
+ hdev = hci_get_route(&sco_pi(sk)->dst, &sco_pi(sk)->src,
+ BDADDR_BREDR);
+ if (!hdev) {
+ err = -EBADFD;
+ break;
+ }
+
+ if (!hdev->get_codec_config_data) {
+ err = -EOPNOTSUPP;
+ break;
+ }
+
+ if (optlen < sizeof(struct bt_codecs) ||
+ optlen > sizeof(buffer)) {
+ err = -EINVAL;
+ break;
+ }
+
+ if (copy_from_sockptr(buffer, optval, optlen)) {
+ err = -EFAULT;
+ break;
+ }
+
+ codecs = (void *)buffer;
+
+ if (codecs->num_codecs > 1) {
+ err = -EINVAL;
+ break;
+ }
+
+ /* configure data path only non-HCI data path is selected */
+ if (codecs->codecs[0].data_path) {
+ err = sco_configure_data_path(hdev, &codecs->codecs[0]);
+ if (err < 0)
+ break;
+
+ if (codecs->codecs[0].id == 0xff) {
+ sco_pi(sk)->codec.cid = codecs->codecs[0].cid;
+ sco_pi(sk)->codec.vid = codecs->codecs[0].vid;
+ }
+ }
+ sco_pi(sk)->codec.id = codecs->codecs[0].id;
+ sco_pi(sk)->codec.data_path = codecs->codecs[0].data_path;
+ break;
+#endif
default:
err = -ENOPROTOOPT;
break;
--
2.17.1
next prev parent reply other threads:[~2021-06-30 8:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 8:07 [PATCH v10 01/10] Bluetooth: Enumerate local supported codec and cache details Kiran K
2021-06-30 8:07 ` [PATCH v10 02/10] Bluetooth: Add support for Read Local Supported Codecs V2 Kiran K
2021-06-30 8:08 ` [PATCH v10 03/10] Bluetooth: btintel: Read supported offload usecases Kiran K
2021-06-30 8:08 ` [PATCH v10 04/10] Bluetooth: Allow querying of supported offload codecs over SCO socket Kiran K
2021-06-30 8:08 ` [PATCH v10 05/10] Bluetooth: btintel: Define callback to fetch data_path_id Kiran K
2021-06-30 8:08 ` Kiran K [this message]
2021-06-30 8:08 ` [PATCH v10 07/10] Bluetooth: btintel: Define a callback to fetch codec config data Kiran K
2021-06-30 8:08 ` [PATCH v10 08/10] Bluetooth: Add support for HCI_Enhanced_Setup_Synchronous_Connection command Kiran K
2021-06-30 20:39 ` Luiz Augusto von Dentz
2021-07-27 7:19 ` K, Kiran
2021-06-30 8:08 ` [PATCH v10 09/10] Bluetooth: Add support for msbc coding format Kiran K
2021-06-30 8:08 ` [PATCH v10 10/10] Bluetooth: Add offload feature under experimental flag Kiran K
2021-06-30 19:56 ` Luiz Augusto von Dentz
2021-07-22 14:01 ` Marcel Holtmann
2021-07-22 17:42 ` Luiz Augusto von Dentz
2021-07-22 17:59 ` Marcel Holtmann
2021-07-22 18:07 ` Luiz Augusto von Dentz
2021-07-22 18:50 ` Marcel Holtmann
2021-07-27 7:21 ` K, Kiran
2021-06-30 9:12 ` [v10,01/10] Bluetooth: Enumerate local supported codec and cache details bluez.test.bot
2021-06-30 20:15 ` [PATCH v10 01/10] " Luiz Augusto von Dentz
2021-07-27 6:56 ` K, Kiran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630080807.12600-6-kiran.k@intel.com \
--to=kiran.k@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).