From: Howard Chung <howardchung@google.com>
To: linux-bluetooth@vger.kernel.org
Cc: Yun-Hao Chung <howardchung@chromium.org>,
Archie Pusaka <apusaka@chromium.org>
Subject: [Bluez PATCH v3] gatt-db: remove redundant check in foreach range
Date: Thu, 29 Jul 2021 11:36:00 +0800 [thread overview]
Message-ID: <20210729113552.Bluez.v3.1.I20397b8350f98567b8d52b895442c768250a6ab3@changeid> (raw)
From: Yun-Hao Chung <howardchung@chromium.org>
svc_start < foreach_data->end has already been checked in a few lines
before.
Reviewed-by: Archie Pusaka <apusaka@chromium.org>
---
Changes in v3:
- resore check svc_start < foreach_data->start and update commit message
Changes in v2:
- remove the entire check
src/shared/gatt-db.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/shared/gatt-db.c b/src/shared/gatt-db.c
index 8bff4d37aaa2..3a02289ce435 100644
--- a/src/shared/gatt-db.c
+++ b/src/shared/gatt-db.c
@@ -1348,9 +1348,9 @@ static void foreach_in_range(void *data, void *user_data)
return;
if (!foreach_data->attr) {
- if (svc_start < foreach_data->start ||
- svc_start > foreach_data->end)
+ if (svc_start < foreach_data->start)
return;
+
return foreach_service_in_range(data, user_data);
}
--
2.32.0.554.ge1b32706d8-goog
next reply other threads:[~2021-07-29 3:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 3:36 Howard Chung [this message]
2021-07-29 3:59 ` [Bluez,v3] gatt-db: remove redundant check in foreach range bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729113552.Bluez.v3.1.I20397b8350f98567b8d52b895442c768250a6ab3@changeid \
--to=howardchung@google.com \
--cc=apusaka@chromium.org \
--cc=howardchung@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).