From: Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Tedd Ho-Jeong An <tedd.an@intel.com>
Subject: [PATCH v6 00/12] Bluetooth: btintel: Refactoring setup routines
Date: Tue, 3 Aug 2021 21:40:20 -0700 [thread overview]
Message-ID: <20210804044032.59729-1-hj.tedd.an@gmail.com> (raw)
From: Tedd Ho-Jeong An <tedd.an@intel.com>
This patch set refactors the multiple setup routines for various Intel devices
to a combined single entry. Here are the highlight of the changes:
1. Updated hci_alloc_dev() to allocate the hdev object with an extra buffer
for the private data. btintel introduces the btintel_data struct and
store it to the private data in hdev object.
2. Added a single entry for setup and shutdown and uses the
HCI_Intel_Read_Version command to identify the device, instead of
relying on the USB VID and PID. The new HCI_Intel_Read_Version command
is used for both legacy ROM, legacy Bootloader and TLV based bootloader.
Also, btintel_configure_setup() is added to setup the most of hdev
callbacks, unless it is a transport specific functions.
After identifying the device, it calls the corresponding setup routines.
These routines were copied from btusb to btintel and changes are none or
very minimal.
3. Keep the state of bootloader in btintel object. The bootloader state
is agnostic to the transport type, so btintel uses the btintel_data
to keep track of the state in the private data section in hdev.
Also, added macros to set/clear/test flags to simplify the code.
5. Cleaned up the exported functions and make it static as much as possible
if not necessary.
6. From the JfP/ThP, the operational firmware support the new TLV based
HCI_Intel_Read_Version command, which confues the usage during the
setup routine. So, the check for firmware variant of those legacy
bootloader sku is added to use the legacy bootloader setup call.
7. All of HCI quirks for Intel devices are moved in the setup routines.
There are several HCI quirks for Intel devices and some of them are
for all Intel devices and some of them are for a specific devices.
The flag for HCI quirks are removed from the .driver_info, and applying
HCI quirks are done in combined setup routine depends on the hw_variant.
8. Combined the setting the MSFT extension support in the combined setup
routine now depends on the hw_variant.
Tedd Ho-Jeong An (12):
Bluetooth: Add support hdev to allocate private data
Bluetooth: btintel: Add combined setup and shutdown functions
Bluetooth: btintel: Refactoring setup routine for legacy ROM sku
Bluetooth: btintel: Add btintel data struct
Bluetooth: btintel: Fix the first HCI command not work with ROM device
Bluetooth: btintel: Fix the LED is not turning off immediately
Bluetooth: btintel: Add combined set_diag functions
Bluetooth: btintel: Refactoring setup routine for bootloader devices
Bluetooth: btintel: Move hci quirks to setup routine
Bluetooth: btintel: Clean the exported function to static
Bluetooth: btintel: Fix the legacy bootloader returns tlv based
version
Bluetooth: btintel: Combine setting MSFT extension
drivers/bluetooth/btintel.c | 1307 ++++++++++++++++++++++++++++--
drivers/bluetooth/btintel.h | 119 ++-
drivers/bluetooth/btusb.c | 1128 +-------------------------
include/net/bluetooth/hci_core.h | 13 +-
net/bluetooth/hci_core.c | 13 +-
5 files changed, 1358 insertions(+), 1222 deletions(-)
--
2.25.1
next reply other threads:[~2021-08-04 4:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 4:40 Tedd Ho-Jeong An [this message]
2021-08-04 4:40 ` [PATCH v6 01/12] Bluetooth: Add support hdev to allocate private data Tedd Ho-Jeong An
2021-08-04 5:15 ` Bluetooth: btintel: Refactoring setup routines bluez.test.bot
2021-08-04 4:40 ` [PATCH v6 02/12] Bluetooth: btintel: Add combined setup and shutdown functions Tedd Ho-Jeong An
2021-08-04 15:22 ` K, Kiran
2021-08-04 4:40 ` [PATCH v6 03/12] Bluetooth: btintel: Refactoring setup routine for legacy ROM sku Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 04/12] Bluetooth: btintel: Add btintel data struct Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 05/12] Bluetooth: btintel: Fix the first HCI command not work with ROM device Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 06/12] Bluetooth: btintel: Fix the LED is not turning off immediately Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 07/12] Bluetooth: btintel: Add combined set_diag functions Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 08/12] Bluetooth: btintel: Refactoring setup routine for bootloader devices Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 09/12] Bluetooth: btintel: Move hci quirks to setup routine Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 10/12] Bluetooth: btintel: Clean the exported function to static Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 11/12] Bluetooth: btintel: Fix the legacy bootloader returns tlv based version Tedd Ho-Jeong An
2021-08-04 4:40 ` [PATCH v6 12/12] Bluetooth: btintel: Combine setting up MSFT extension Tedd Ho-Jeong An
2021-08-04 15:00 ` [PATCH v6 00/12] Bluetooth: btintel: Refactoring setup routines Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804044032.59729-1-hj.tedd.an@gmail.com \
--to=hj.tedd.an@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).