From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Andy Shevchenko Andy Shevchenko <andy.shevchenko@gmail.com>,
Sinan Kaya <okaya@codeaurora.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v4 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()
Date: Thu, 27 Sep 2018 22:13:31 +0530 [thread overview]
Message-ID: <32aa77b08ef306d017b615cd270e3529@codeaurora.org> (raw)
In-Reply-To: <20180927004810.124185-3-mka@chromium.org>
Hi Matthias,
On 2018-09-27 06:18, Matthias Kaehlcke wrote:
> Use the new API to get the BD address instead of reading it directly
> from the device tree.
>
> Also remove an unncessary pair of braces in the same area of code.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Changes in v4:
> - added 'Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>' tag
>
> Changes in v3:
> - added 'Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>' tag
>
> Changes in v2:
> - pass bdaddr_t instead of byte pointer + len
> ---
> drivers/bluetooth/btqcomsmd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bluetooth/btqcomsmd.c
> b/drivers/bluetooth/btqcomsmd.c
> index 7df3eed1ef5e..ff74d2c46991 100644
> --- a/drivers/bluetooth/btqcomsmd.c
> +++ b/drivers/bluetooth/btqcomsmd.c
> @@ -172,11 +172,9 @@ static int btqcomsmd_probe(struct platform_device
> *pdev)
> /* The local-bd-address property is usually injected by the
> * bootloader which has access to the allocated BD address.
> */
> - if (!of_property_read_u8_array(pdev->dev.of_node, "local-bd-address",
> - (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {
> + if (!device_get_bd_address(&pdev->dev, &btq->bdaddr))
> dev_info(&pdev->dev, "BD address %pMR retrieved from device-tree",
> &btq->bdaddr);
> - }
>
> hdev = hci_alloc_dev();
> if (!hdev)
Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
--
Regards
Balakrishna.
prev parent reply other threads:[~2018-09-27 16:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 0:48 [PATCH v4 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR) Matthias Kaehlcke
2018-09-27 0:48 ` [PATCH v4 1/2] Bluetooth: Add device_get_bd_address() Matthias Kaehlcke
2018-09-27 6:50 ` Sakari Ailus
2018-09-27 16:41 ` Balakrishna Godavarthi
2018-09-27 16:47 ` Sinan Kaya
2018-09-27 17:13 ` Matthias Kaehlcke
2018-10-04 17:33 ` Matthias Kaehlcke
2018-10-15 18:03 ` Matthias Kaehlcke
2018-10-15 18:06 ` Marcel Holtmann
2018-10-15 18:51 ` Matthias Kaehlcke
2018-10-16 6:52 ` Marcel Holtmann
2018-10-16 21:02 ` Matthias Kaehlcke
2018-10-22 21:07 ` Pavel Machek
2018-09-27 0:48 ` [PATCH v4 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address() Matthias Kaehlcke
2018-09-27 16:43 ` Balakrishna Godavarthi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32aa77b08ef306d017b615cd270e3529@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).