linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: linux-bluetooth@vger.kernel.org,
	Maarten Fonville <maarten.fonville@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: SMP: Workaround Microsoft Surface Precision Mouse bug
Date: Sat, 6 Jul 2019 15:58:03 +0200	[thread overview]
Message-ID: <47663D4D-8800-4A7A-87A6-4708651C40EC@holtmann.org> (raw)
In-Reply-To: <20190618224747.446-1-szymon.janc@codecoup.pl>

Hi Szymon,

> Microsoft Surface Precision Mouse provides bogus identity address when
> pairing. It connects with Static Random address but provides Public
> Address in SMP Identity Address Information PDU. Address has same
> value but type is different. Workaround this by dropping IRK if ID
> address discrepancy is detected.
> 
>> HCI Event: LE Meta Event (0x3e) plen 19
>      LE Connection Complete (0x01)
>        Status: Success (0x00)
>        Handle: 75
>        Role: Master (0x00)
>        Peer address type: Random (0x01)
>        Peer address: E0:52:33:93:3B:21 (Static)
>        Connection interval: 50.00 msec (0x0028)
>        Connection latency: 0 (0x0000)
>        Supervision timeout: 420 msec (0x002a)
>        Master clock accuracy: 0x00
> 
> ....
> 
>> ACL Data RX: Handle 75 flags 0x02 dlen 12
>      SMP: Identity Address Information (0x09) len 7
>        Address type: Public (0x00)
>        Address: E0:52:33:93:3B:21
> 
> Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
> Tested-by: Maarten Fonville <maarten.fonville@gmail.com>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199461
> Cc: stable@vger.kernel.org
> ---
> net/bluetooth/smp.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel


      parent reply	other threads:[~2019-07-06 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 22:47 [PATCH] Bluetooth: SMP: Workaround Microsoft Surface Precision Mouse bug Szymon Janc
2019-07-06 13:51 ` Marcel Holtmann
2019-07-06 13:58 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47663D4D-8800-4A7A-87A6-4708651C40EC@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=maarten.fonville@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=szymon.janc@codecoup.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).