RE: Admin policy series

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 8648 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=522677

---Test result---

Test Summary:
CheckPatch                    FAIL      4.37 seconds
GitLint                       PASS      1.40 seconds
Prep - Setup ELL              PASS      41.48 seconds
Build - Prep                  PASS      0.10 seconds
Build - Configure             PASS      7.30 seconds
Build - Make                  FAIL      100.83 seconds
Make Check                    FAIL      0.37 seconds
Make Distcheck                FAIL      105.14 seconds
Build w/ext ELL - Configure   PASS      7.26 seconds
Build w/ext ELL - Make        FAIL      89.75 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
mcap: add adapter authorization
WARNING:NEW_TYPEDEFS: do not add new typedefs
#139: FILE: profiles/health/mcap.h:253:
+typedef guint (* mcap_authorize_cb) (const bdaddr_t *src, const bdaddr_t *dst,

WARNING:LONG_LINE_COMMENT: line length of 93 exceeds 80 columns
#150: FILE: profiles/health/mcap.h:279:
+	mcap_authorize_cb	authorize_cb;		/* Method to request authorization */

- total: 0 errors, 2 warnings, 133 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] mcap: add adapter authorization" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

core: add device_added and device_removed to adapter driver
WARNING:SPACING: Unnecessary space before function pointer arguments
#130: FILE: src/adapter.h:114:
+	void (*device_added) (struct btd_adapter *adapter,

WARNING:SPACING: Unnecessary space before function pointer arguments
#132: FILE: src/adapter.h:116:
+	void (*device_removed) (struct btd_adapter *adapter,

- total: 0 errors, 2 warnings, 112 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] core: add device_added and device_removed to adapter driver" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

plugins/admin_policy: add ServiceAllowList property
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#63: FILE: plugins/admin.c:186:
+					const GDBusPropertyTable *property,
 					                         ^

- total: 1 errors, 0 warnings, 164 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] plugins/admin_policy: add ServiceAllowList property" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

plugins/admin_policy: add AffectedByPolicy property
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#65: FILE: plugins/admin.c:254:
+					const GDBusPropertyTable *property,
 					                         ^

- total: 1 errors, 0 warnings, 242 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] plugins/admin_policy: add AffectedByPolicy property" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

plugins/admin_policy: persist policy settings
WARNING:LINE_SPACING: Missing a blank line after declarations
#151: FILE: plugins/admin.c:336:
+	struct queue *uuid_list = NULL;
+	gchar **uuids = NULL;

- total: 0 errors, 1 warnings, 408 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] plugins/admin_policy: persist policy settings" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
android/health.c: In function ‘bt_health_register’:
android/health.c:2007:9: error: too few arguments to function ‘mcap_create_instance’
 2007 |  mcap = mcap_create_instance(&adapter_addr, BT_IO_SEC_MEDIUM, 0, 0,
      |         ^~~~~~~~~~~~~~~~~~~~
In file included from android/health.c:34:
./profiles/health/mcap.h:405:23: note: declared here
  405 | struct mcap_instance *mcap_create_instance(const bdaddr_t *src,
      |                       ^~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:6955: android/health.o] Error 1
make: *** [Makefile:4147: all] Error 2


##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
android/health.c: In function ‘bt_health_register’:
android/health.c:2007:9: error: too few arguments to function ‘mcap_create_instance’
 2007 |  mcap = mcap_create_instance(&adapter_addr, BT_IO_SEC_MEDIUM, 0, 0,
      |         ^~~~~~~~~~~~~~~~~~~~
In file included from android/health.c:34:
./profiles/health/mcap.h:405:23: note: declared here
  405 | struct mcap_instance *mcap_create_instance(const bdaddr_t *src,
      |                       ^~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:6955: android/health.o] Error 1
make: *** [Makefile:10436: check] Error 2


##############################
Test: Make Distcheck - FAIL
Desc: Run distcheck to check the distribution
Output:
../../android/health.c: In function ‘bt_health_register’:
../../android/health.c:2007:9: error: too few arguments to function ‘mcap_create_instance’
 2007 |  mcap = mcap_create_instance(&adapter_addr, BT_IO_SEC_MEDIUM, 0, 0,
      |         ^~~~~~~~~~~~~~~~~~~~
In file included from ../../android/health.c:34:
../../profiles/health/mcap.h:405:23: note: declared here
  405 | struct mcap_instance *mcap_create_instance(const bdaddr_t *src,
      |                       ^~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:6955: android/health.o] Error 1
make[1]: *** [Makefile:4147: all] Error 2
make: *** [Makefile:10357: distcheck] Error 1


##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
android/health.c: In function ‘bt_health_register’:
android/health.c:2007:9: error: too few arguments to function ‘mcap_create_instance’
 2007 |  mcap = mcap_create_instance(&adapter_addr, BT_IO_SEC_MEDIUM, 0, 0,
      |         ^~~~~~~~~~~~~~~~~~~~
In file included from android/health.c:34:
./profiles/health/mcap.h:405:23: note: declared here
  405 | struct mcap_instance *mcap_create_instance(const bdaddr_t *src,
      |                       ^~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:6955: android/health.o] Error 1
make: *** [Makefile:4147: all] Error 2




---
Regards,
Linux Bluetooth