From: Marcel Holtmann <marcel@holtmann.org>
To: Sonny Sasaka <sonnysasaka@chromium.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
Eric Caruso <ejcaruso@chromium.org>
Subject: Re: [PATCH] device: Add device type property
Date: Thu, 9 Apr 2020 20:11:58 +0200 [thread overview]
Message-ID: <6A574E50-BBF3-4967-9C93-6F4B6DAFB47D@holtmann.org> (raw)
In-Reply-To: <20200401221320.12105-1-sonnysasaka@chromium.org>
Hi Sonny,
> This allows us to gather information about whether a device
> supports BR/EDR, BLE, or both. It appears as DBus Property
> "Type" on the org.bluez.Device1 interface.
> ---
> doc/device-api.txt | 5 +++++
> src/device.c | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 36 insertions(+)
my preference is not to combine API documentation patches with code.
>
> diff --git a/doc/device-api.txt b/doc/device-api.txt
> index 65d8fee37..ceb68d2f6 100644
> --- a/doc/device-api.txt
> +++ b/doc/device-api.txt
> @@ -158,6 +158,11 @@ Properties string Address [readonly]
>
> The Bluetooth class of device of the remote device.
>
> + string Type [readonly, optional]
> +
> + The carriers supported by this remote device. If it
> + exists, it can be one of "BR/EDR", "LE", or "DUAL".
> +
So all values need to be lower case. That is just how we design all API.
If we do this, then I think the name “Bearer” might be better. Also it might be better as array{string} actually.
Regards
Marcel
next prev parent reply other threads:[~2020-04-09 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 22:13 [PATCH] device: Add device type property Sonny Sasaka
2020-04-09 18:11 ` Marcel Holtmann [this message]
2020-04-09 21:05 ` Sonny Sasaka
2020-04-10 6:51 ` Marcel Holtmann
2020-05-19 23:12 ` Sonny Sasaka
2020-05-20 6:49 ` Marcel Holtmann
2020-05-21 1:07 ` Sonny Sasaka
2020-05-21 7:01 ` Marcel Holtmann
2020-05-21 16:24 ` Sonny Sasaka
-- strict thread matches above, loose matches on Subject: below --
2017-02-09 1:05 mcchou
2017-02-09 7:37 ` Marcel Holtmann
2017-02-09 8:07 ` Szymon Janc
2017-02-09 9:40 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A574E50-BBF3-4967-9C93-6F4B6DAFB47D@holtmann.org \
--to=marcel@holtmann.org \
--cc=ejcaruso@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sonnysasaka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).