From: Marcel Holtmann <marcel@holtmann.org>
To: Archie Pusaka <apusaka@google.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
Archie Pusaka <apusaka@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6 0/7] MSFT offloading support for advertisement monitor
Date: Mon, 25 Jan 2021 16:09:08 +0100 [thread overview]
Message-ID: <6C36E164-E3DC-44D3-A223-E75DC33CC090@holtmann.org> (raw)
In-Reply-To: <20210122083617.3163489-1-apusaka@google.com>
Hi Archie,
> This series of patches manages the hardware offloading part of MSFT
> extension API. The full documentation can be accessed by this link:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/microsoft-defined-bluetooth-hci-commands-and-events
>
> Only four of the HCI commands are planned to be implemented:
> HCI_VS_MSFT_Read_Supported_Features (implemented in previous patch),
> HCI_VS_MSFT_LE_Monitor_Advertisement,
> HCI_VS_MSFT_LE_Cancel_Monitor_Advertisement, and
> HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable.
> These are the commands which would be used for advertisement monitor
> feature. Only if the controller supports the MSFT extension would
> these commands be sent. Otherwise, software-based monitoring would be
> performed in the user space instead.
>
> Thanks in advance for your feedback!
>
> Archie
>
> Changes in v6:
> * New patch "advmon offload MSFT interleave scanning integration"
> * New patch "disable advertisement filters during suspend"
>
> Changes in v5:
> * Discard struct flags on msft_data and use it's members directly
>
> Changes in v4:
> * Change the logic of merging add_adv_patterns_monitor with rssi
> * Aligning variable declaration on mgmt.h
> * Replacing the usage of BT_DBG with bt_dev_dbg
>
> Changes in v3:
> * Flips the order of rssi and pattern_count on mgmt struct
> * Fix return type of msft_remove_monitor
>
> Changes in v2:
> * Add a new opcode instead of modifying an existing one
> * Also implement the new MGMT opcode and merge the functionality with
> the old one.
>
> Archie Pusaka (6):
> Bluetooth: advmon offload MSFT add rssi support
> Bluetooth: advmon offload MSFT add monitor
> Bluetooth: advmon offload MSFT remove monitor
> Bluetooth: advmon offload MSFT handle controller reset
> Bluetooth: advmon offload MSFT handle filter enablement
> Bluetooth: advmon offload MSFT interleave scanning integration
>
> Howard Chung (1):
> Bluetooth: disable advertisement filters during suspend
>
> include/net/bluetooth/hci_core.h | 36 ++-
> include/net/bluetooth/mgmt.h | 16 ++
> net/bluetooth/hci_core.c | 174 +++++++++---
> net/bluetooth/hci_request.c | 49 +++-
> net/bluetooth/mgmt.c | 391 +++++++++++++++++++-------
> net/bluetooth/msft.c | 460 ++++++++++++++++++++++++++++++-
> net/bluetooth/msft.h | 30 ++
> 7 files changed, 1015 insertions(+), 141 deletions(-)
all 7 patches have been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2021-01-25 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:36 [PATCH v6 0/7] MSFT offloading support for advertisement monitor Archie Pusaka
2021-01-22 8:36 ` [PATCH v6 1/7] Bluetooth: advmon offload MSFT add rssi support Archie Pusaka
2021-01-22 10:47 ` [v6,1/7] " bluez.test.bot
2021-01-22 8:36 ` [PATCH v6 2/7] Bluetooth: advmon offload MSFT add monitor Archie Pusaka
2021-01-22 8:36 ` [PATCH v6 3/7] Bluetooth: advmon offload MSFT remove monitor Archie Pusaka
2021-01-22 8:36 ` [PATCH v6 4/7] Bluetooth: advmon offload MSFT handle controller reset Archie Pusaka
2021-01-22 8:36 ` [PATCH v6 5/7] Bluetooth: advmon offload MSFT handle filter enablement Archie Pusaka
2021-01-22 8:36 ` [PATCH v6 6/7] Bluetooth: advmon offload MSFT interleave scanning integration Archie Pusaka
2021-01-22 8:36 ` [PATCH v6 7/7] Bluetooth: disable advertisement filters during suspend Archie Pusaka
2021-01-25 15:09 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6C36E164-E3DC-44D3-A223-E75DC33CC090@holtmann.org \
--to=marcel@holtmann.org \
--cc=apusaka@chromium.org \
--cc=apusaka@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).