Re: [PATCH 2/2] Bluetooth: btbcm: Add default address for BCM2076B1

From: Ferry Toth <ftoth@exalondelft.nl>
To: Stephan Gerhold <stephan@gerhold.net>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 2/2] Bluetooth: btbcm: Add default address for BCM2076B1
Date: Tue, 5 Mar 2019 19:26:14 +0100	[thread overview]
Message-ID: <7b48753f-f103-f522-68c5-38479feb4552@exalondelft.nl> (raw)
In-Reply-To: <20190305130901.56660-2-stephan@gerhold.net>

Op 05-03-19 om 14:09 schreef Stephan Gerhold:
> BCM2076B1 appears to use 20:76:A0:00:56:79 as default address.
> This address is used by at least 5 devices with the AMPAK AP6476
> module and is also suspicious because it starts with the chip name
> 2076 (followed by a different revision A0 for some reason).
With BCM43340 (Edison) it's the same principle. With the fake address I 
found everything (in user space) seems to work except PAN/NAP (bnep) and 
no decent error message anywhere making this quite hard to debug.
> Add it to the list of default addresses and leave it up to the
> user to configure a valid one.

Which way is the user supposed to configure the valid one?

The only way I found is bd_addr (tool from bluez that is not normally 
built/installed).

Using this tool requires hci0 to be up and bluetoothd to be restarted if 
that was already running, which is quite inconvenient.

I also saw there was a patch to put the address in dt.

But nowhere did I find a kernel parameter to pass the address. Did I 
miss something?

>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> drivers/bluetooth/btbcm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index ea1a20a49f91..35394076267b 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -34,6 +34,7 @@
> #define BDADDR_BCM20702A0 (&(bdaddr_t) {{0x00, 0xa0, 0x02, 0x70, 0x20, 
> 0x00}})
> #define BDADDR_BCM20702A1 (&(bdaddr_t) {{0x00, 0x00, 0xa0, 0x02, 0x70, 
> 0x20}})
> +#define BDADDR_BCM2076B1 (&(bdaddr_t) {{0x79, 0x56, 0x00, 0xa0, 0x76, 
> 0x20}})
> #define BDADDR_BCM43430A0 (&(bdaddr_t) {{0xac, 0x1f, 0x12, 0xa0, 0x43, 
> 0x43}})
> #define BDADDR_BCM4324B3 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb3, 0x24, 
> 0x43}})
> #define BDADDR_BCM4330B1 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb1, 0x30, 
> 0x43}})
> @@ -69,6 +70,9 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
> * The address 20:70:02:A0:00:00 indicates a BCM20702A1 controller
> * with no configured address.
> *
> + * The address 20:76:A0:00:56:79 indicates a BCM2076B1 controller
> + * with no configured address.
> + *
> * The address 43:24:B3:00:00:00 indicates a BCM4324B3 controller
> * with waiting for configuration state.
> *
> @@ -80,6 +84,7 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
> */
> if (!bacmp(&bda->bdaddr, BDADDR_BCM20702A0) ||
> !bacmp(&bda->bdaddr, BDADDR_BCM20702A1) ||
> + !bacmp(&bda->bdaddr, BDADDR_BCM2076B1) ||
> !bacmp(&bda->bdaddr, BDADDR_BCM4324B3) ||
> !bacmp(&bda->bdaddr, BDADDR_BCM4330B1) ||
> !bacmp(&bda->bdaddr, BDADDR_BCM43430A0)) {