From: Marcel Holtmann <marcel@holtmann.org>
To: Fabian Henneke <fabian.henneke@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Johan Hedberg <johan.hedberg@gmail.com>
Subject: Re: [PATCH] hidp: Let hidp_send_message return number of queued bytes
Date: Mon, 15 Jul 2019 21:37:29 +0200 [thread overview]
Message-ID: <88E1CAE0-E1ED-417B-8157-2F4A5E9B5C0E@holtmann.org> (raw)
In-Reply-To: <f46a923b-caa8-83bb-1b64-44bb0ef25ca6@gmail.com>
Hi Fabian,
> Let hidp_send_message return the number of successfully queued bytes
> instead of an unconditional 0.
>
> With the return value fixed to 0, other drivers relying on hidp, such as
> hidraw, can not return meaningful values from their respective
> implementations of write(). In particular, with the current behavior, a
> hidraw device's write() will have different return values depending on
> whether the device is connected via USB or Bluetooth, which makes it
> harder to abstract away the transport layer.
>
> Signed-off-by: Fabian Henneke <fabian.henneke@gmail.com>
> ---
> net/bluetooth/hidp/core.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2019-07-15 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:40 [PATCH] hidp: Let hidp_send_message return number of queued bytes Fabian Henneke
2019-07-15 19:37 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88E1CAE0-E1ED-417B-8157-2F4A5E9B5C0E@holtmann.org \
--to=marcel@holtmann.org \
--cc=fabian.henneke@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).