From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses
Date: Fri, 28 Dec 2018 12:41:24 +0530 [thread overview]
Message-ID: <952efcf13141c6f92d66ddbe396d4983@codeaurora.org> (raw)
In-Reply-To: <20181227201856.GJ261387@google.com>
HI Matthias,
On 2018-12-28 01:48, Matthias Kaehlcke wrote:
> On Thu, Dec 27, 2018 at 01:01:31PM +0530, Balakrishna Godavarthi wrote:
>> wcn3990 requires a power pulse to turn ON/OFF along with
>> regulators. Sometimes we are observing the power pulses are sent
>> out with some time delay, due to queuing these commands. This is
>> causing synchronization issues with chip, which intern delay the
>> chip setup or may end up with communication issues.
>>
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> ---
>> Changes in v6:
>> * added serdev_device_write_flush() in qca_send_power_pulse
>> instead during the power off pulse.
>>
>> Changes in v5:
>> * added serdev_device_write_flush() in qca_power_off().
>>
>> ---
>> drivers/bluetooth/hci_qca.c | 38
>> ++++++++++++++-----------------------
>> 1 file changed, 14 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index f036c8f98ea3..507a2355c758 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct
>> hci_uart *hu, unsigned int speed)
>> hci_uart_set_baudrate(hu, speed);
>> }
>>
>> -static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
>> +static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd)
>> {
>> - struct hci_uart *hu = hci_get_drvdata(hdev);
>> - struct qca_data *qca = hu->priv;
>> - struct sk_buff *skb;
>> + int ret;
>>
>> /* These power pulses are single byte command which are sent
>> * at required baudrate to wcn3990. On wcn3990, we have an external
>> @@ -1029,19 +1027,17 @@ static int qca_send_power_pulse(struct hci_dev
>> *hdev, u8 cmd)
>> * save power. Disabling hardware flow control is mandatory while
>> * sending power pulses to SoC.
>> */
>> - bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd);
>> -
>> - skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
>> - if (!skb)
>> - return -ENOMEM;
>> -
>> + serdev_device_write_flush(hu->serdev);
>> + bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
>
> nit: why clutter the code flow by putting the log statement in the
> middle of code that is actually doing something with the serial
> interface?
>
> In case you respin anyway I suggest to structure it like this:
>
> bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
>
> hci_uart_set_flow_control(hu, true);
> serdev_device_write_flush(hu->serdev);
> ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
>
>
>> hci_uart_set_flow_control(hu, true);
>> + ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
>> + if (ret < 0) {
>> + bt_dev_err(hu->hdev, "failed to send power pulse %02x to SoC",
>
> nit: especially on 'embedded' devices 'SoC' is typically associated
> with the CPU running Linux, you might want to change it to
> 'controller'.
>
[Bala]: will update.
>> + cmd);
>> + return ret;
>> + }
>>
>> - skb_put_u8(skb, cmd);
>> - hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
>> -
>> - skb_queue_tail(&qca->txq, skb);
>> - hci_uart_tx_wakeup(hu);
>> + serdev_device_wait_until_sent(hu->serdev, 0);
>>
>> /* Wait for 100 uS for SoC to settle down */
>> usleep_range(100, 200);
>
> I said earlier the delay here should be enough to ensure that the byte
> gets transferred from a hardware buffer/FIFO to the controller,
> however that didn't take into account that the power pulses are sent
> with a baudrate of 2400. That translates to ~240 bytes/s, hence a
> delay of 5 ms is needed to be on the safe side.
>
[Bala]: sure will update the delay of 5 ms.
> In case you change the delay please also update the comment to make
> clear this is not only time for the BT controller to settle, but also
> to guarantee that the command was actually sent to the controller.
>
[Bala]: will update the comment.
> So far it seems no problems have been observed, though this could be
> thanks to the 100 ms delay in qca_wcn3990_init().
>
> Cheers
>
> Matthias
--
Regards
Balakrishna.
next prev parent reply other threads:[~2018-12-28 7:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-12-27 20:18 ` Matthias Kaehlcke
2018-12-28 7:11 ` Balakrishna Godavarthi [this message]
2018-12-27 7:31 ` [PATCH v6 2/6] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
2018-12-27 20:25 ` Matthias Kaehlcke
2018-12-28 7:49 ` Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 4/6] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990 Balakrishna Godavarthi
2018-12-27 21:00 ` Matthias Kaehlcke
2018-12-28 11:25 ` Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 6/6] Bluetooth: btqca: inject command complete event during fw download Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952efcf13141c6f92d66ddbe396d4983@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).