From: Marcel Holtmann <marcel@holtmann.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bluetooth: hci_nokia: Save a few cycles in 'nokia_enqueue()'
Date: Thu, 26 Sep 2019 08:34:28 +0200 [thread overview]
Message-ID: <BC4B9659-D8B7-4583-9D1E-F412ED989948@holtmann.org> (raw)
In-Reply-To: <20190919195208.2254-1-christophe.jaillet@wanadoo.fr>
Hi Christophe,
> 'skb_pad()' a few lines above already initializes the "padded" byte to 0.
> So there is no need to do it twice.
>
> All what is needed is to increase the len of the skb. So 'skb_put(..., 1)'
> is enough here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/bluetooth/hci_nokia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2019-09-26 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 19:52 [PATCH] bluetooth: hci_nokia: Save a few cycles in 'nokia_enqueue()' Christophe JAILLET
2019-09-26 6:34 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC4B9659-D8B7-4583-9D1E-F412ED989948@holtmann.org \
--to=marcel@holtmann.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).