From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
Cc: Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] ath3k: add warning when switch pid is not working
Date: Thu, 27 Sep 2018 12:48:17 +0200 [thread overview]
Message-ID: <BE213F03-E020-4046-BF60-8723902BCD71@holtmann.org> (raw)
In-Reply-To: <20180907233549.GE3379@giustizia.org>
Hi Luiz,
> This patch adds a warning message in the ath3k driver when
> ath3k_switch_pid() returns error.
>
> This event happens in a specific laptop, with an adapter which
> identifies itself as 0cf3:0036. Surprisingly, the adapter works even
> after this event - hence a warning is chosen instead of an error.
>
> The current version of ath3k doesn't check the return value of
> ath3k_switch_pid() and so this event may remain undetected in the
> original version.
if works anyway, why bother with a warning? I have no idea what benefit this has.
Regards
Marcel
next prev parent reply other threads:[~2018-09-27 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 23:35 [PATCH] ath3k: add warning when switch pid is not working Luiz Carlos Ramos
2018-09-27 10:48 ` Marcel Holtmann [this message]
2018-09-27 16:15 ` Luiz Carlos Ramos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE213F03-E020-4046-BF60-8723902BCD71@holtmann.org \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lramos.prof@yahoo.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).