From: Marcel Holtmann <marcel@holtmann.org>
To: Bharat Bhusan Panda <bharat.b.panda@intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] support fast advertising interval
Date: Tue, 30 Oct 2018 08:55:28 +0100 [thread overview]
Message-ID: <C18F1F83-945E-4FBF-97A3-E55184123932@holtmann.org> (raw)
In-Reply-To: <1535359591-27842-1-git-send-email-bharat.b.panda@intel.com>
Hi Bharat,
> Changes made to add support for fast advertising interval as per
> core 4.1 specification, section 9.3.11.2.
>
> A peripheral device enetering any of the following GAP modes and
> sending either non-connectable advertising events or scannable undirected
> advertising events should use adv_fast_interval2(100ms - 150ms)
> for adv_fast_period(30s).
> - Non-Discoverable Mode
> - Non-Connectable Mode
> - Limited Discoverable Mode
> - General Discoverable Mode
>
> Signed-off-by: Bharat Bhusan Panda <bharat.b.panda@intel.com>
> ---
> include/net/bluetooth/hci_core.h | 2 ++
> net/bluetooth/hci_request.c | 22 ++++++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index b619a19..2fe908c 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -1456,6 +1456,8 @@ struct hci_mgmt_chan {
> #define DISCOV_INTERLEAVED_INQUIRY_LEN 0x04
> #define DISCOV_BREDR_INQUIRY_LEN 0x08
> #define DISCOV_LE_RESTART_DELAY msecs_to_jiffies(200) /* msec */
> +#define DISCOV_LE_FAST_ADV_INT_MIN 100 /* msec */
> +#define DISCOV_LE_FAST_ADV_INT_MAX 150 /* msec */
>
> void mgmt_fill_version_info(void *ver);
> int mgmt_new_settings(struct hci_dev *hdev);
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 66c0781..5cf3ef9 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -1005,6 +1005,28 @@ void __hci_req_enable_advertising(struct hci_request *req)
> else
> cp.type = LE_ADV_NONCONN_IND;
>
> + /* As per core 4.1 spec, section 9.3.11.2: A peripheral device
> + * enetering any of the following GAP modes and sending either
“entering”
> + * non-connectable advertising events or scannable undirected
> + * advertising events should use adv_fast_interval2(100ms - 150ms)
> + * for adv_fast_period(30s).
> + *
> + * - Non-Discoverable Mode
> + * - Non-Connectable Mode
> + * - Limited Discoverable Mode
> + * - General Discoverable Mode
> + */
> + if ((cp.type == LE_ADV_NONCONN_IND) || (cp.type = LE_ADV_SCAN_IND)) {
Remove the unneeded (x == x) braces.
> + if ((hci_dev_test_flag(hdev, HCI_DISCOVERABLE)) ||
> + (hci_dev_test_flag(hdev, HCI_LIMITED_DISCOVERABLE)) ||
> + (hdev->discovery.limited == true)) {
Same here and the indentation is all messed up. In addition of just quoting the spec text, it would be good also document why these conditions are the the correct match. And why hdev->discovery.limited is even in this mix.
> + cp.min_interval =
> + cpu_to_le16(DISCOV_LE_FAST_ADV_INT_MIN);
> + cp.max_interval =
> + cpu_to_le16(DISCOV_LE_FAST_ADV_INT_MAX);
> + }
> + }
> +
Regards
Marcel
prev parent reply other threads:[~2018-10-30 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 8:46 [PATCH] support fast advertising interval Bharat Bhusan Panda
2018-09-27 10:57 ` Marcel Holtmann
2018-09-27 11:16 ` Luiz Augusto von Dentz
2018-10-01 9:29 ` Panda, Bharat B
2018-10-30 6:25 ` Panda, Bharat B
2018-10-30 7:55 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C18F1F83-945E-4FBF-97A3-E55184123932@holtmann.org \
--to=marcel@holtmann.org \
--cc=bharat.b.panda@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).