From: Marcel Holtmann <marcel@holtmann.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Rui <rui@arrandale.lan>
Subject: Re: [PATCHv2] Bluetooth: trivial: tidy up printk message output from btrtl.
Date: Thu, 26 Sep 2019 08:34:10 +0200 [thread overview]
Message-ID: <C9B9ED17-F82B-4F25-996E-C1880AC49E1B@holtmann.org> (raw)
In-Reply-To: <20190909184446.9049-1-rsalvaterra@gmail.com>
Hi Rui,
> v2: also remove new line from hci_h5.c
>
> The rtl_dev_* calls in the Realtek USB Bluetooth driver add unnecessary
> device prefixes and new lines at the end of most messages, which make the
> dmesg output look like this:
>
> [ 5.667121] sd 0:0:0:0: [sda] Attached SCSI disk
> [ 5.736869] Bluetooth: hci0: RTL: rtl: examining hci_ver=06 hci_rev=000a lmp_ver=06 lmp_subver=8821
>
> [ 5.737853] Bluetooth: hci0: RTL: rom_version status=0 version=1
>
> [ 5.737857] Bluetooth: hci0: RTL: rtl: loading rtl_bt/rtl8821a_fw.bin
>
> [ 5.737946] Bluetooth: hci0: RTL: rtl: loading rtl_bt/rtl8821a_config.bin
>
> [ 5.737965] bluetooth hci0: Direct firmware load for rtl_bt/rtl8821a_config.bin failed with error -2
> [ 5.737972] Bluetooth: hci0: RTL: cfg_sz -2, total sz 17428
>
> [ 5.997375] ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
>
> Clean this up by removing extraneous new lines and redundant device prefixes,
> with the following result:
>
> [ 5.667008] sd 0:0:0:0: [sda] Attached SCSI disk
> [ 5.716945] Bluetooth: hci0: rtl: examining hci_ver=06 hci_rev=000a lmp_ver=06 lmp_subver=8821
> [ 5.718745] Bluetooth: hci0: rtl: rom_version status=0 version=1
> [ 5.718749] Bluetooth: hci0: rtl: loading rtl_bt/rtl8821a_fw.bin
> [ 5.718830] Bluetooth: hci0: rtl: loading rtl_bt/rtl8821a_config.bin
> [ 5.718849] bluetooth hci0: Direct firmware load for rtl_bt/rtl8821a_config.bin failed with error -2
> [ 5.718858] Bluetooth: hci0: rtl: cfg_sz -2, total sz 17428
> [ 5.997400] ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
>
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
> ---
> drivers/bluetooth/btrtl.c | 62 +++++++++++++++++++-------------------
> drivers/bluetooth/btrtl.h | 8 ++---
> drivers/bluetooth/hci_h5.c | 2 +-
> 3 files changed, 36 insertions(+), 36 deletions(-)
I have some similar patch in my tree. Can you check what is still missing and send a new version. Thanks.
Regards
Marcel
next prev parent reply other threads:[~2019-09-26 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 18:44 [PATCHv2] Bluetooth: trivial: tidy up printk message output from btrtl Rui Salvaterra
2019-09-26 6:34 ` Marcel Holtmann [this message]
2019-09-26 8:59 ` Rui Salvaterra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9B9ED17-F82B-4F25-996E-C1880AC49E1B@holtmann.org \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=rui@arrandale.lan \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).