From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Fix unnecessary error message for HCI request completion
Date: Thu, 29 Nov 2018 12:32:04 +0200 [thread overview]
Message-ID: <CABBYNZJnY6DGyXaOD1JvBidtae74BhwtmrYia8Q6NNwX-EVftQ@mail.gmail.com> (raw)
In-Reply-To: <20181127093746.7414-1-johan.hedberg@gmail.com>
Hi Johan,
On Tue, Nov 27, 2018 at 11:39 AM Johan Hedberg <johan.hedberg@gmail.com> wrote:
>
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> In case a command which completes in Command Status was sent using the
> hci_cmd_send-family of APIs there would be a misleading error in the
> hci_get_cmd_complete function, since the code would be trying to fetch
> the Command Complete parameters when there are none.
>
> Avoid the misleading error and silently bail out from the function in
> case the received event is a command status.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> net/bluetooth/hci_event.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index ef9928d7b4fb..ac2826ce162b 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -5711,6 +5711,12 @@ static bool hci_get_cmd_complete(struct hci_dev *hdev, u16 opcode,
> return true;
> }
>
> + /* Check if request ended in Command Status - no way to retreive
> + * any extra parameters in this case.
> + */
> + if (hdr->evt == HCI_EV_CMD_STATUS)
> + return false;
> +
> if (hdr->evt != HCI_EV_CMD_COMPLETE) {
> bt_dev_err(hdev, "last event is not cmd complete (0x%2.2x)",
> hdr->evt);
> --
> 2.17.2
Ack.
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2018-11-29 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 9:37 [PATCH] Bluetooth: Fix unnecessary error message for HCI request completion Johan Hedberg
2018-11-29 10:32 ` Luiz Augusto von Dentz [this message]
2018-12-19 13:37 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZJnY6DGyXaOD1JvBidtae74BhwtmrYia8Q6NNwX-EVftQ@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).