From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Ross Burton <ross.burton@intel.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation
Date: Wed, 9 Oct 2019 18:01:17 +0300 [thread overview]
Message-ID: <CABBYNZJpmJARG9Qi7HFtPJAvoNFHDLcr3aw_gU7wwoXsp6pZUw@mail.gmail.com> (raw)
In-Reply-To: <20191008095832.3473-1-ross.burton@intel.com>
Hi Ross,
On Tue, Oct 8, 2019 at 1:03 PM Ross Burton <ross.burton@intel.com> wrote:
>
> In parallel out-of-tree builds it's possible that obexd/src/builtin.h is
> generated before the target directory has been implicitly created. Solve this by
> creating the directory before writing into it.
> ---
> Makefile.obexd | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.obexd b/Makefile.obexd
> index d36874770..de59d297b 100644
> --- a/Makefile.obexd
> +++ b/Makefile.obexd
> @@ -104,6 +104,7 @@ BUILT_SOURCES += obexd/src/builtin.h
> obexd/src/plugin.$(OBJEXT): obexd/src/builtin.h
>
> obexd/src/builtin.h: obexd/src/genbuiltin $(obexd_builtin_sources)
> + $(AM_V_at)$(MKDIR_P) $(dir $@)
> $(AM_V_GEN)$(srcdir)/obexd/src/genbuiltin $(obexd_builtin_modules) > $@
>
> CLEANFILES += obexd/src/builtin.h $(builtin_files) obexd/src/obex.service
> --
> 2.20.1
Applied, thanks.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2019-10-09 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:58 [PATCH BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation Ross Burton
2019-10-09 15:01 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZJpmJARG9Qi7HFtPJAvoNFHDLcr3aw_gU7wwoXsp6pZUw@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).