From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v3 1/6] a2dp: Fix crash when endpoint respond with an error
Date: Tue, 7 May 2019 13:17:08 +0300 [thread overview]
Message-ID: <CABBYNZKMkjZ3UyuHuyP-VhV4FfTd-fW1Z4+Z5t1NLHrG8P5kDQ@mail.gmail.com> (raw)
In-Reply-To: <20190506124310.19151-1-luiz.dentz@gmail.com>
Hi,
On Mon, May 6, 2019 at 3:43 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> If endpoint respond with an error the callback will be called with size
> set to -1 not 0.
> ---
> profiles/audio/a2dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
> index d0676b577..74ada3bbe 100644
> --- a/profiles/audio/a2dp.c
> +++ b/profiles/audio/a2dp.c
> @@ -2418,7 +2418,7 @@ static void select_cb(struct a2dp_setup *setup, void *ret, int size)
> struct avdtp_media_codec_capability *codec;
> int err;
>
> - if (size) {
> + if (size >= 0) {
> caps_add_codec(&setup->caps, setup->sep->codec, ret, size);
> goto done;
> }
> --
> 2.20.1
Applied.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2019-05-07 10:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 12:43 [PATCH v3 1/6] a2dp: Fix crash when endpoint respond with an error Luiz Augusto von Dentz
2019-05-06 12:43 ` [PATCH v3 2/6] a2dp: Try aborting when switching endpoints Luiz Augusto von Dentz
2019-05-06 12:43 ` [PATCH v3 3/6] a2dp: Update last used on open indication Luiz Augusto von Dentz
2019-05-06 12:43 ` [PATCH v3 4/6] a2dp: Fix reconfiguring when there multiple devices connected Luiz Augusto von Dentz
2019-05-06 12:43 ` [PATCH v3 5/6] a2dp: Fix useless statement Luiz Augusto von Dentz
2019-05-06 12:43 ` [PATCH v3 6/6] a2dp: Reword LastUsed Luiz Augusto von Dentz
2019-05-06 12:46 ` Luiz Augusto von Dentz
2019-05-06 13:02 ` Pali Rohár
2019-05-07 8:52 ` Pali Rohár
2019-05-07 10:13 ` Luiz Augusto von Dentz
2019-05-07 18:57 ` Pali Rohár
2019-06-07 13:04 ` Pali Rohár
2019-06-07 15:18 ` Luiz Augusto von Dentz
2019-06-10 12:35 ` Pali Rohár
2019-06-10 13:02 ` Luiz Augusto von Dentz
2019-05-07 10:17 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZKMkjZ3UyuHuyP-VhV4FfTd-fW1Z4+Z5t1NLHrG8P5kDQ@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).