From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Howard Chung <howardchung@google.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Luiz Augusto Von Dentz <luiz.von.dentz@intel.com>,
ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>
Subject: Re: [Bluez PATCH v1] tools/btmgmt: Fix missing setting string in btmgmt
Date: Thu, 26 Mar 2020 14:08:36 -0700 [thread overview]
Message-ID: <CABBYNZLL85ghDDSR_ziBE9_bs7uorS+kj9ERuoTHf9crAhuvpQ@mail.gmail.com> (raw)
In-Reply-To: <20200326161415.Bluez.v1.1.Ieaecd20492214a9bdb962417481330ff73240527@changeid>
Hi Howard,
On Thu, Mar 26, 2020 at 1:16 AM Howard Chung <howardchung@google.com> wrote:
>
> Both PHY configuration and wide band speech are not set in
> btmgmt.c.
> ---
>
> tools/btmgmt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/btmgmt.c b/tools/btmgmt.c
> index f631de4aa..b1820b41c 100644
> --- a/tools/btmgmt.c
> +++ b/tools/btmgmt.c
> @@ -353,6 +353,8 @@ static const char *settings_str[] = {
> "privacy",
> "configuration",
> "static-addr",
> + "phy-configuration",
> + "wide-band-speech",
> };
>
> static const char *settings2str(uint32_t settings)
> --
> 2.25.1.696.g5e7596f4ac-goog
Applied, thanks.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2020-03-26 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 8:14 [Bluez PATCH v1] tools/btmgmt: Fix missing setting string in btmgmt Howard Chung
2020-03-26 21:08 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZLL85ghDDSR_ziBE9_bs7uorS+kj9ERuoTHf9crAhuvpQ@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=howardchung@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).