linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume Martres <smarter@ubuntu.com>
To: sathish.narasimman@intel.com, marcel@holtmann.org
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v6 2/2] bluetooth:btusb: handle msbc audio over USB Endpoints
Date: Mon, 23 Mar 2020 16:01:39 +0100	[thread overview]
Message-ID: <CAMM3rS01a6UH=atXGUL6gqAvS9Mit4hqhzhBrEtVX7-nWP92Pg@mail.gmail.com> (raw)
In-Reply-To: <20200321165551.11928-1-smarter@ubuntu.com>

On Sat, 21 Mar 2020 at 17:55, Guillaume Martres <smarter@ubuntu.com> wrote:
> Since then, I was made aware of the existence of this patchset, after applying
> this patch (and [3] which apparently only exists as v5 and not v6), my
> headphones stopped sending zero-filled packets, but:
> - the recorded audio quality is again extremely bad and robotic.
> - when audio is being played, the headphones do not emit any sound.

I figured out what the problem was: pulseaudio assumes an MTU of 48
but with this
patch it now ends up being 60, I've left a comment on the pulseaudio MR [1].
After fixing this, audio input and output seem to be working correctly, however
from time to time pulseaudio fails to decode an mSBC packet, but I don't know
whose fault that is.

[1]: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/254#note_444249

On Sat, 21 Mar 2020 at 17:55, Guillaume Martres <smarter@ubuntu.com> wrote:
>
> From: Guillaume Martres <smarter3@gmail.com>
>
> Hi Sathish, Marcel,
>
> > I would really prefer to have some Tested-by lines from people that can verify that this patch works.
>
> Here's my experience: a recent pulseaudio MR [1] added support for mSBC. When I
> tried it using my laptop (Intel AX200) and headphones (Bose Headphone 700), the
> voice quality was extremely bad. I eventually realized that this could be fixed
> by ignoring all zero-filled packets sent by the headphones when decoding
> mSBC [2], after that everything worked fine.
>
> Since then, I was made aware of the existence of this patchset, after applying
> this patch (and [3] which apparently only exists as v5 and not v6), my
> headphones stopped sending zero-filled packets, but:
> - the recorded audio quality is again extremely bad and robotic.
> - when audio is being played, the headphones do not emit any sound.
>
> Note that I applied this patchset on top of the current Ubuntu 20.04 kernel [4],
> let me know if it's worth retesting on top of the mainline kernel, or if there
> is something else I could try.
>
> Hope this helps,
> Guillaume
>
>
> [1]: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/254
> [2]: https://gitlab.freedesktop.org/smarter/pulseaudio/-/commit/bb716b03002841e1092b4200935566d5c1a951fe
> [3]: https://www.spinics.net/lists/linux-bluetooth/msg82149.html
> [4]: https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal/commit/?h=Ubuntu-5.4.0-18.22&id=93dfa5b8e12fed29933f3451db44d88c0e4b5aed

  reply	other threads:[~2020-03-23 15:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05  8:32 [PATCH v6 2/2] bluetooth:btusb: handle msbc audio over USB Endpoints Sathish Narsimman
2019-12-10  4:57 ` Sathish Narasimman
2019-12-16  4:50   ` Sathish Narasimman
2020-01-04  9:58 ` Marcel Holtmann
2020-01-06  8:39   ` chethan tn
2020-02-06  6:08     ` Sathish Narasimman
2020-03-21 16:55   ` Guillaume Martres
2020-03-23 15:01     ` Guillaume Martres [this message]
2020-03-30 22:38 ` Marcel Holtmann
2020-04-02 15:12   ` Sathish Narasimman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMM3rS01a6UH=atXGUL6gqAvS9Mit4hqhzhBrEtVX7-nWP92Pg@mail.gmail.com' \
    --to=smarter@ubuntu.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sathish.narasimman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).