From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
bgodavar@codeaurora.org, Alain Michaud <alainm@chromium.org>,
Marcel Holtmann <marcel@holtmann.org>,
ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Enable WBS support for wcn3991
Date: Thu, 14 May 2020 10:44:59 -0700 [thread overview]
Message-ID: <CANFp7mX0+fLgZgtVPin1B=AC-N4qSk6aPzsqcwYcazM_M1WLmw@mail.gmail.com> (raw)
In-Reply-To: <20200514163048.GO4525@google.com>
Hi,
On Thu, May 14, 2020 at 9:30 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Hi Abhishek,
>
> On Wed, May 13, 2020 at 08:41:25PM -0700, Abhishek Pandit-Subedi wrote:
> > WCN3991 supports transparent WBS (host encoded mSBC). Add a flag to the
> > device match data to show WBS is supported.
>
> In general this looks good to me, a few nits inside.
>
> > This requires the matching firmware for WCN3991 in linux-firmware:
> > 1a8b0dc00f77 (qca: Enable transparent WBS for WCN3991)
> >
> > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> > ---
> >
> > drivers/bluetooth/hci_qca.c | 23 +++++++++++++++++------
> > 1 file changed, 17 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> > index b3fd07a6f8127..305976c4dcf42 100644
> > --- a/drivers/bluetooth/hci_qca.c
> > +++ b/drivers/bluetooth/hci_qca.c
> > @@ -75,6 +75,9 @@ enum qca_flags {
> > QCA_HW_ERROR_EVENT
> > };
> >
> > +enum qca_driver_flags {
> > + QCA_DRV_WIDEBAND_SPEECH_SUPPORTED = 0x1,
>
> s/0x1/BIT(0)/
Will change in next version.
>
> > +};
>
> The 'driver'/'DRV' midfix is a bit misleading. WBS support is a device
> capability, it's not something the driver supports or doesn't. Maybe
> name it 'qca_capabilities' or similar.
>
> > /* HCI_IBS transmit side sleep protocol states */
> > enum tx_ibs_states {
> > @@ -187,10 +190,11 @@ struct qca_vreg {
> > unsigned int load_uA;
> > };
> >
> > -struct qca_vreg_data {
> > +struct qca_device_data {
> > enum qca_btsoc_type soc_type;
> > struct qca_vreg *vregs;
> > size_t num_vregs;
> > + uint32_t flags;
>
> capabilities?
Capabilities sounds good to me.
Thanks for the feedback.
Abhishek
prev parent reply other threads:[~2020-05-14 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 3:41 [PATCH] Bluetooth: hci_qca: Enable WBS support for wcn3991 Abhishek Pandit-Subedi
2020-05-14 16:30 ` Matthias Kaehlcke
2020-05-14 17:44 ` Abhishek Pandit-Subedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANFp7mX0+fLgZgtVPin1B=AC-N4qSk6aPzsqcwYcazM_M1WLmw@mail.gmail.com' \
--to=abhishekpandit@chromium.org \
--cc=alainm@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).