linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bluez mailing list <linux-bluetooth@vger.kernel.org>,
	Hemantg <hemantg@codeaurora.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	Rocky Liao <rjliao@codeaurora.org>,
	Yoni Shavit <yshavit@google.com>,
	abhishekpandit@chromium.org,
	Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Subject: Re: [PATCH v4] Bluetooth: hci_qca: Bug fixes while collecting controller memory dump
Date: Tue, 18 Feb 2020 09:30:40 +0100	[thread overview]
Message-ID: <D1EF879E-B55C-4904-A0E7-0065B999B6D4@holtmann.org> (raw)
In-Reply-To: <20200214161715.2166-1-bgodavar@codeaurora.org>

Hi Balakrishna,

> This patch will fix the below issues
> 1. Discarding memory dump events if memdump state is moved to
>    MEMDUMP_TIMEOUT.
> 2. Fixed race conditions between qca_hw_error() and qca_controller_memdump
>    while free memory dump buffers using mutex lock
> 3. Moved timeout timer to delayed work queue
> 4. Injecting HW error event in a case when dumps failed to receive and HW
>    error event is not yet received.
> 5. Clearing hw error and command timeout function callbacks before
>    sending pre shutdown command.
> 
> Collecting memory dump will follow any of the below sequence.
> 
> Sequence 1:
>   Receiving Memory dump events from the controller
>   Received entire dump in stipulated time
>   Received HW error event from the controller
>   Controller Reset from HOST
> 
> Sequence 2:
>   Receiving Memory dump events from the controller
>   Failed to Receive entire dump in stipulated time
>   A Timeout schedules and if no HW error event received a fake HW
>     error event will be injected.
>   Controller Reset from HOST.
> 
> Sequence 3:
>   Received HW error event
>   HOST trigger SSR by sending crash packet to controller.
>   Received entire dump in stipulated time
>   Controller Reset from HOST
> 
> Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
> Reported-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> ---
> drivers/bluetooth/hci_qca.c | 101 ++++++++++++++++++++++++------------
> 1 file changed, 67 insertions(+), 34 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


      reply	other threads:[~2020-02-18  8:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 16:17 [PATCH v4] Bluetooth: hci_qca: Bug fixes while collecting controller memory dump Balakrishna Godavarthi
2020-02-18  8:30 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D1EF879E-B55C-4904-A0E7-0065B999B6D4@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=abhishekpandit@chromium.org \
    --cc=bgodavar@codeaurora.org \
    --cc=gubbaven@codeaurora.org \
    --cc=hemantg@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=rjliao@codeaurora.org \
    --cc=yshavit@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).