On 25 Feb 2020, at 16:48, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > The word 'offset' is used ambiguously to mean 'byte offset within > a page', 'byte offset from the start of the file' and 'page offset > from the start of the file'. Use 'index' to mean 'page offset > from the start of the file' throughout the readahead code. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good to me. Reviewed-by: Zi Yan — Best Regards, Yan Zi