linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] btrfs-progs: make quiet to overrule verbose
Date: Wed, 30 Oct 2019 03:42:56 +0800	[thread overview]
Message-ID: <0bf84f2d-d125-8c06-cb1a-e5498d84d196@oracle.com> (raw)
In-Reply-To: <79a8fa97-6aff-3698-2263-548fbb68baf0@oracle.com>

On 26/10/19 9:01 AM, Anand Jain wrote:
> On 26/10/19 12:35 AM, David Sterba wrote:
>> On Fri, Oct 25, 2019 at 09:56:14AM +0800, Anand Jain wrote:
>>> On 25/10/19 7:51 AM, Anand Jain wrote:
>>>>
>>>>
>>>> On 24/10/19 11:41 PM, David Sterba wrote:
>>>>> On Thu, Oct 24, 2019 at 02:28:22PM +0800, Anand Jain wrote:
>>>>>> When both the options (--quiet and --verbose) in btrfs send and 
>>>>>> receive
>>>>>> is specified, we need at least one of it to overrule the other,
>>>>>> irrespective
>>>>>> of the chronological order of options.
>>>>>
>>>>> I think the common behaviour is to respect the order of appearance on
>>>>> the commandline.
>>>>
>>>>     I am fine with this. Will fix it as this.
>>>
>>>    Question: command -v -q -v should be equal to command -v, right?
>>
>> No, that would be equivalent to the default level:
>>
>> verbose starts with 1            ()
>> verbose++                (-v)
>> verbose = 0                (-q)
>> verbose++ is now 1, which is not -v    ()
>>
> 
> Oh I was thinking its a bug, and no need to carry forward to the global
> verbose. Will make it look like this.
> 

What do you think should be the final %verbose value when both
local and global verbose and or quiet options are specified?

For example:
  btrfs -v -q sub-command -v
  btrfs -q sub-command -v
  btrfs -vv sub-command -q
  etc..

Thanks, Anand


  reply	other threads:[~2019-10-29 19:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  6:28 [RFC PATCH 0/3] btrfs-progs: make quiet to overrule verbose Anand Jain
2019-10-24  6:28 ` [RFC PATCH 1/3] btrfs-progs: send: let option quiet " Anand Jain
2019-10-24  6:28 ` [RFC PATCH 2/3] btrfs-progs: receive: " Anand Jain
2019-10-24  6:28 ` [RFC PATCH 3/3] btrfs-progs: receive: make quiet really quiet Anand Jain
2019-10-24 15:41 ` [RFC PATCH 0/3] btrfs-progs: make quiet to overrule verbose David Sterba
2019-10-24 23:51   ` Anand Jain
2019-10-25  1:56     ` Anand Jain
2019-10-25 16:35       ` David Sterba
2019-10-26  1:01         ` Anand Jain
2019-10-29 19:42           ` Anand Jain [this message]
2019-11-01 15:18             ` David Sterba
2019-11-04  6:26               ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bf84f2d-d125-8c06-cb1a-e5498d84d196@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).