From: David Disseldorp <ddiss@suse.de>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2 v3] xfstests: add test for btrfs ioctl clone operation
Date: Mon, 26 May 2014 17:48:34 +0200 [thread overview]
Message-ID: <20140526174834.18fd03df@f163.suse.de> (raw)
In-Reply-To: <1400950255-24346-1-git-send-email-fdmanana@gmail.com>
On Sat, 24 May 2014 17:50:55 +0100, Filipe David Borba Manana wrote:
> This is a test to verify that the btrfs ioctl clone operation is
> able to clone extents of a file to different positions of the file,
> that is, the source and target files are the same. Existing tests
> only cover the case where the source and target files are different.
>
> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
> ---
>
> V2: Made the test exercise a more complex code path in the btrfs ioctl clone
> code. Now we have extents with different sizes and make the cloner process
> partial extents and split existing extents with smaller ones.
>
> V3: Add tests to verify that after writing to a cloned extent, the original
> extent isn't modified, that defragmenting a file with cloned extents
> doesn't change the file contents and that all the tests have the same
> exact semantics (as observed by an application/user) regardless of the
> following options (and any combination): cow/nodatacow/compression.
Looks good.
Reviewed-by: David Disseldorp <ddiss@suse.de>
next prev parent reply other threads:[~2014-05-26 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 4:05 [PATCH 1/2] xfstests: add helper require function _require_btrfs_cloner Filipe David Borba Manana
2014-05-23 4:05 ` [PATCH 2/2] xfstests: add test for btrfs ioctl clone operation Filipe David Borba Manana
2014-05-23 9:44 ` David Disseldorp
2014-05-23 13:19 ` [PATCH 2/2 v2] " Filipe David Borba Manana
2014-05-24 16:50 ` [PATCH 2/2 v3] " Filipe David Borba Manana
2014-05-26 15:48 ` David Disseldorp [this message]
2014-05-23 9:39 ` [PATCH 1/2] xfstests: add helper require function _require_btrfs_cloner David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526174834.18fd03df@f163.suse.de \
--to=ddiss@suse.de \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).