From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] Btrfs: check if destination root is read-only for deduplication
Date: Thu, 13 Dec 2018 17:07:40 +0100 [thread overview]
Message-ID: <20181213160740.GE23615@twin.jikos.cz> (raw)
In-Reply-To: <20181212180559.15249-4-fdmanana@kernel.org>
On Wed, Dec 12, 2018 at 06:05:58PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Checking if the destination root is read-only was being performed only for
> clone operations. Make deduplication check it as well, as it does not make
> sense to not do it, even if it is an operation that does not change the
> file contents (such as defrag for example, which checks first if the root
> is read-only).
And this is also change in user-visible behaviour of dedupe, so this
needs to be verified if it's not breaking existing tools.
next prev parent reply other threads:[~2018-12-13 16:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 18:05 [PATCH 0/4] Btrfs: a few more cleanups and fixes for clone/deduplication fdmanana
2018-12-12 18:05 ` [PATCH 1/4] Btrfs: move duplicated nodatasum check into common reflink/dedupe helper fdmanana
2019-01-11 14:55 ` David Sterba
2018-12-12 18:05 ` [PATCH 2/4] Btrfs: use cross mount point check for cloning and deduplication fdmanana
2018-12-13 16:02 ` David Sterba
2019-01-11 14:38 ` David Sterba
2018-12-12 18:05 ` [PATCH 3/4] Btrfs: check if destination root is read-only for deduplication fdmanana
2018-12-13 16:07 ` David Sterba [this message]
2019-01-31 16:39 ` Filipe Manana
2019-01-31 16:44 ` Hugo Mills
2019-02-18 15:38 ` David Sterba
2019-02-18 16:55 ` Filipe Manana
2019-02-12 17:59 ` Filipe Manana
2019-02-20 16:41 ` Zygo Blaxell
2019-02-20 16:54 ` Filipe Manana
2019-02-20 17:17 ` Zygo Blaxell
2019-02-22 11:13 ` Filipe Manana
2019-02-22 17:25 ` David Sterba
2019-02-21 16:54 ` Zygo Blaxell
2019-02-18 16:01 ` David Sterba
2018-12-12 18:05 ` [PATCH 4/4] Btrfs: remove no longer needed range length checks " fdmanana
2018-12-13 12:20 ` Nikolay Borisov
2019-01-31 16:31 ` Filipe Manana
2019-02-12 17:58 ` Filipe Manana
2019-02-18 15:10 ` David Sterba
2018-12-13 12:19 ` [PATCH 0/4] Btrfs: a few more cleanups and fixes for clone/deduplication Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213160740.GE23615@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).