From: Dan Robertson <dan@dlrobertson.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fs/btrfs: init csum_list before possible free
Date: Thu, 21 Feb 2019 14:57:27 +0000 [thread overview]
Message-ID: <20190221145723.GA25507@nessie> (raw)
In-Reply-To: <20190219163144.GR9874@twin.jikos.cz>
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
> Thanks, it's been there since the first merge of scrub, but hard to hit.
Yeah, very hard to hit. Debated submitting a patch, but the fix seemed
simple enough, so figured I'd send one in.
Side note: I noticed most of the time ENOMEM is hit in fs/btrfs BUG or BUG_ON is
called. Would it be better (more in line with the fs/btrfs style) to call BUG or
BUG_ON e.g. BUG_ON(!sbio) instead of goto nomem at fs/btrfs/scrub.c:592?
Cheers,
Dan
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-21 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 2:56 [PATCH] fs/btrfs: init csum_list before possible free Dan Robertson
2019-02-19 5:45 ` Nikolay Borisov
2019-02-19 16:31 ` David Sterba
2019-02-21 14:57 ` Dan Robertson [this message]
2019-02-22 15:57 ` David Sterba
2019-02-22 16:45 ` Dan Robertson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221145723.GA25507@nessie \
--to=dan@dlrobertson.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).