From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v1.1 1/3] btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check
Date: Thu, 8 Aug 2019 16:54:08 +0200 [thread overview]
Message-ID: <20190808145407.GA8267@twin.jikos.cz> (raw)
In-Reply-To: <20190807140843.2728-2-wqu@suse.com>
On Wed, Aug 07, 2019 at 10:08:41PM +0800, Qu Wenruo wrote:
> +
> +static int check_extent_item(struct extent_buffer *leaf,
> + struct btrfs_key *key, int slot)
> +{
> + struct btrfs_fs_info *fs_info = leaf->fs_info;
> + struct btrfs_extent_item *ei;
> + bool is_tree_block = false;
> + u64 ptr; /* Current pointer inside inline refs */
While u64 is wide enough, I suggest to use unsigned long as the
intermediate type for pointer conversions.
next prev parent reply other threads:[~2019-08-08 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 14:08 [PATCH v1.1 0/3] btrfs: tree-checker: Add extent items check Qu Wenruo
2019-08-07 14:08 ` [PATCH v1.1 1/3] btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check Qu Wenruo
2019-08-08 14:54 ` David Sterba [this message]
2019-08-08 23:55 ` WenRuo Qu
2019-08-09 13:34 ` David Sterba
2019-08-07 14:08 ` [PATCH v1.1 2/3] btrfs: tree-checker: Add simple keyed refs check Qu Wenruo
2019-08-07 14:08 ` [PATCH v1.1 3/3] btrfs: tree-checker: Add EXTENT_DATA_REF check Qu Wenruo
2019-08-08 14:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808145407.GA8267@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).