From: David Sterba <dsterba@suse.cz>
To: Vladimir Panteleev <git@panteleev.md>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: balance: check for full-balance before background fork
Date: Tue, 20 Aug 2019 16:32:58 +0200 [thread overview]
Message-ID: <20190820143258.GS24086@twin.jikos.cz> (raw)
In-Reply-To: <20190817231434.1034-1-git@vladimir.panteleev.md>
On Sat, Aug 17, 2019 at 11:14:34PM +0000, Vladimir Panteleev wrote:
> Move the full-balance warning to before the fork, so that the user can
> see and react to it.
>
> Notes on test:
>
> - Don't use grep -q, as it causes a SIGPIPE during the countdown, and
> the balance thus doesn't start.
>
> - The "balance cancel" is superfluous as the last command, but it
> provides some idempotence and allows adding more tests below it.
>
> Fixes: https://github.com/kdave/btrfs-progs/issues/168
>
> Signed-off-by: Vladimir Panteleev <git@vladimir.panteleev.md>
Applied, thanks. The issues can be referenced as
Issue: #168
> --- a/tests/cli-tests/002-balance-full-no-filters/test.sh
> +++ b/tests/cli-tests/002-balance-full-no-filters/test.sh
> @@ -18,4 +18,9 @@ run_check $SUDO_HELPER "$TOP/btrfs" balance start "$TEST_MNT"
> run_check $SUDO_HELPER "$TOP/btrfs" balance --full-balance "$TEST_MNT"
> run_check $SUDO_HELPER "$TOP/btrfs" balance "$TEST_MNT"
>
> +run_check_stdout $SUDO_HELPER "$TOP/btrfs" balance start --background "$TEST_MNT" |
> + grep -F "Full balance without filters requested." ||
This needs -q, otherwise the text appears in the output of make. Fixed.
next prev parent reply other threads:[~2019-08-20 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 23:14 [PATCH] btrfs-progs: balance: check for full-balance before background fork Vladimir Panteleev
2019-08-20 14:32 ` David Sterba [this message]
2019-08-20 14:46 ` Vladimir Panteleev
2019-08-26 16:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820143258.GS24086@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=git@panteleev.md \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).