From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, jthumshirn@suse.de, dsterba@suse.cz
Subject: Re: [PATCH Fix-title-prefix] btrfs-progs: misc-tests-021 fix restore overlapped on disk's stale data
Date: Thu, 12 Sep 2019 19:49:35 +0200 [thread overview]
Message-ID: <20190912174935.GL2850@twin.jikos.cz> (raw)
In-Reply-To: <20190904132947.1232-1-anand.jain@oracle.com>
On Wed, Sep 04, 2019 at 09:29:47PM +0800, Anand Jain wrote:
> As misc-tests/021 image dump is restored on the same original loop
> device, this overlaps with the stale data and makes the test pass
> falsely.
>
> Fix this by using a new device for restore.
>
> And also, the btrfs-image dump and restore doesn't not collect the data,
> so any read on the files should be avoided. So instead of file data use
> file stat data for the md5sum.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> Reported-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
Applied, thanks.
next prev parent reply other threads:[~2019-09-12 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 2:26 [PATCH] btrfs_progs: mkfs: match devid order to the stripe index Anand Jain
2019-06-28 2:44 ` Qu Wenruo
2019-06-28 3:28 ` Anand Jain
2019-06-28 6:01 ` Qu Wenruo
2019-07-03 13:21 ` David Sterba
2019-08-27 2:02 ` Anand Jain
2019-09-02 8:01 ` Anand Jain
2019-09-02 16:22 ` David Sterba
2019-09-03 12:06 ` David Sterba
2019-09-04 11:10 ` Anand Jain
2019-09-12 17:54 ` David Sterba
2019-12-10 15:42 ` Filipe Manana
2019-12-11 1:45 ` Qu Wenruo
2019-12-11 8:58 ` Filipe Manana
2019-09-03 10:46 ` Johannes Thumshirn
2019-09-04 12:54 ` [PATCH] btrfs: misc-tests-021 fix restore overlapped on disk's stale data Anand Jain
2019-09-04 13:29 ` [PATCH Fix-title-prefix] btrfs-progs: " Anand Jain
2019-09-04 14:05 ` Johannes Thumshirn
2019-09-04 14:06 ` Nikolay Borisov
2019-09-10 7:43 ` Anand Jain
2019-09-12 17:49 ` David Sterba [this message]
2019-09-10 7:37 ` [PATCH] btrfs_progs: mkfs: match devid order to the stripe index Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912174935.GL2850@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).