linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: David Sterba <dsterba@suse.com>,
	Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] btrfs: remove cached space_info in btrfs_statfs()
Date: Fri, 25 Oct 2019 18:41:32 +0200	[thread overview]
Message-ID: <20191025164132.GQ3001@twin.jikos.cz> (raw)
In-Reply-To: <20191024154455.19370-2-jthumshirn@suse.de>

On Thu, Oct 24, 2019 at 05:44:54PM +0200, Johannes Thumshirn wrote:
> In btrfs_statfs() we cache fs_info::space_info in a local variable only
> to use it once in a list_for_each_rcu() statement.
> 
> Not only is the local variable unnecessary it even makes the code harder
> to follow as it's not clear which list it is iterating.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Added to misc-next as it's not related to the statfs change itself.

  reply	other threads:[~2019-10-25 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 15:44 [PATCH 0/2] Provide an estimation of (free/total) inodes in statfs Johannes Thumshirn
2019-10-24 15:44 ` [PATCH 1/2] btrfs: remove cached space_info in btrfs_statfs() Johannes Thumshirn
2019-10-25 16:41   ` David Sterba [this message]
2019-10-24 15:44 ` [PATCH 2/2] btrfs: provide an estimated number of inodes for statfs Johannes Thumshirn
2019-10-25  0:56   ` Qu Wenruo
2019-10-25  8:55     ` Johannes Thumshirn
2019-10-25 10:05   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025164132.GQ3001@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).