From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: receive: make option quiet work
Date: Fri, 1 Nov 2019 11:55:25 +0100 [thread overview]
Message-ID: <20191101105525.GK3001@twin.jikos.cz> (raw)
In-Reply-To: <20191025102520.41170-1-anand.jain@oracle.com>
On Fri, Oct 25, 2019 at 06:25:20PM +0800, Anand Jain wrote:
> Even when -q option specified, the receive sub-command is not quiet as
> show below.
>
> btrfs receive -q -f /tmp/t /btrfs1
> At snapshot ss3
>
> It must be quiet atlest when its been asked to be quiet.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> This is how I checked if fstests/btrfs-progs-tests is using receive -q option.
> find ./xfstests-devel -type f -exec grep --color -i -I "receive" {} \; \
> -print | grep "\-q"
> find ./btrfs-progs/tests -type f -exec grep --color -i -I "receive" {} \; \
> -print | grep "\-q"
>
> they aren't using it. So its fine.
>
> cmds/receive.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cmds/receive.c b/cmds/receive.c
> index 4b03938ea3eb..c4827c1dd999 100644
> --- a/cmds/receive.c
> +++ b/cmds/receive.c
> @@ -269,7 +269,8 @@ static int process_snapshot(const char *path, const u8 *uuid, u64 ctransid,
> goto out;
> }
>
> - fprintf(stdout, "At snapshot %s\n", path);
> + if (g_verbose)
> + fprintf(stdout, "At snapshot %s\n", path);
Right, this seems to be forgotten in commit 33b4acc7df00bf "btrfs-progs:
receive: add option for quiet mode" that updated the verbosity.
Added to devel, thanks.
prev parent reply other threads:[~2019-11-01 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 10:25 [PATCH] btrfs-progs: receive: make option quiet work Anand Jain
2019-11-01 10:55 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101105525.GK3001@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).