From: Adam Borowski <kilobyte@angband.pl>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Cc: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
dsterba@suse.cz, waxhead <waxhead@dirtcellar.net>,
linux-btrfs@vger.kernel.org
Subject: Re: Why do we need these mount options?
Date: Sat, 16 Jan 2021 16:19:33 +0100 [thread overview]
Message-ID: <20210116151933.GA374963@angband.pl> (raw)
In-Reply-To: <94a65b16-3a23-6862-9de6-169620302308@gmail.com>
On Sat, Jan 16, 2021 at 10:39:51AM +0300, Andrei Borzenkov wrote:
> 15.01.2021 06:54, Zygo Blaxell пишет:
> > On the other hand, I'm in favor of deprecating the whole discard option
> > and going with fstrim instead. discard in its current form tends to
> > increase write wear rather than decrease it, especially on metadata-heavy
> > workloads. discard is roughly equivalent to running fstrim thousands
> > of times a day, which is clearly bad for many (most? all?) SSDs.
>
> My (probably naive) understanding so far was that trim on SSD marks
> areas as "unused" which means SSD need to copy less residual data from
> erase block when reusing it. Assuming TRIM unit is (significantly)
> smaller than erase block.
>
> I would appreciate if you elaborate how trim results in more write on SSD?
The areas are not only marked as unused, but also zeroed. To keep the
zeroing semantic, every discard must be persisted, thus requiring a write
to the SSD's metadata (not btrfs metadata) area.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀ .--[ Makefile ]
⣾⠁⢠⠒⠀⣿⡁ # beware of races
⢿⡄⠘⠷⠚⠋⠀ all: pillage burn
⠈⠳⣄⠀⠀⠀⠀ `----
next prev parent reply other threads:[~2021-01-16 17:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 2:12 Why do we need these mount options? waxhead
2021-01-14 16:37 ` David Sterba
2021-01-15 0:02 ` waxhead
2021-01-15 15:29 ` David Sterba
2021-01-16 1:47 ` waxhead
2021-01-15 3:54 ` Zygo Blaxell
2021-01-15 9:32 ` waxhead
2021-01-16 0:42 ` Zygo Blaxell
2021-01-16 1:57 ` waxhead
2021-01-16 3:51 ` Zygo Blaxell
2021-01-16 7:39 ` Andrei Borzenkov
2021-01-16 15:19 ` Adam Borowski [this message]
2021-01-16 17:21 ` Andrei Borzenkov
2021-01-16 20:01 ` Zygo Blaxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116151933.GA374963@angband.pl \
--to=kilobyte@angband.pl \
--cc=arvidjaar@gmail.com \
--cc=ce3g8jdj@umail.furryterror.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=waxhead@dirtcellar.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).