From: David Sterba <dsterba@suse.cz>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 02/30] btrfs: Use a folio in write_dev_supers()
Date: Thu, 25 Apr 2024 16:44:03 +0200 [thread overview]
Message-ID: <20240425144403.GQ3492@twin.jikos.cz> (raw)
In-Reply-To: <20240420025029.2166544-3-willy@infradead.org>
On Sat, Apr 20, 2024 at 03:49:57AM +0100, Matthew Wilcox (Oracle) wrote:
> @@ -3812,8 +3814,7 @@ static int write_dev_supers(struct btrfs_device *device,
> bio->bi_iter.bi_sector = bytenr >> SECTOR_SHIFT;
> bio->bi_private = device;
> bio->bi_end_io = btrfs_end_super_write;
> - __bio_add_page(bio, page, BTRFS_SUPER_INFO_SIZE,
> - offset_in_page(bytenr));
> + bio_add_folio_nofail(bio, folio, BTRFS_SUPER_INFO_SIZE, offset);
Compilation fails when btrfs is built as a module, bio_add_folio_nofail()
is not exported. I can keep __bio_add_page() and the conversion can be
done later.
next prev parent reply other threads:[~2024-04-25 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240420025029.2166544-1-willy@infradead.org>
2024-04-20 2:49 ` [PATCH 01/30] btrfs: Use a folio in wait_dev_supers() Matthew Wilcox (Oracle)
2024-04-23 12:25 ` Johannes Thumshirn
2024-04-20 2:49 ` [PATCH 02/30] btrfs: Use a folio in write_dev_supers() Matthew Wilcox (Oracle)
2024-04-23 12:26 ` Johannes Thumshirn
2024-04-25 14:44 ` David Sterba [this message]
2024-04-25 16:38 ` Matthew Wilcox
2024-04-20 2:49 ` [PATCH 03/30] btrfs: Use the folio iterator in btrfs_end_super_write() Matthew Wilcox (Oracle)
2024-04-23 12:26 ` Johannes Thumshirn
2024-04-20 2:49 ` [PATCH 04/30] btrfs: Remove use of the folio error flag Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425144403.GQ3492@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).