From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
herbert@gondor.apana.org.au
Cc: linux-btrfs@vger.kernel.org, linux-crypto@vger.kernel.org,
qat-linux@intel.com, embg@meta.com, cyan@meta.com,
brian.will@intel.com, weigang.li@intel.com,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: [RFC PATCH 0/6] btrfs: offload zlib-deflate to accelerators
Date: Fri, 26 Apr 2024 11:54:23 +0100 [thread overview]
Message-ID: <20240426110941.5456-1-giovanni.cabiddu@intel.com> (raw)
Add support for zlib compression and decompression through the acomp
APIs in BTRFS. This enables [de]compression operations to be offloaded
to accelerators. This is a rework of [1].
This set also re-enables zlib-deflate in the Crypto API and in the QAT
driver as they were removed in [2] since there was no user in kernel.
The re-enablement is done by reverting the commits that removed such
feature.
The code has been benchmarked on a system with the following specs:
* Dual socket Intel(R) Xeon(R) Platinum 8470N
* 512GB (16x32GB DDR5 4800 MT/s [4800 MT/s])
* 4 NVMe disks (349.3G INTEL SSDPE21K375GA)
* 2 QAT 4xxx devices, one per socket, configured for compression only
* Kernel 6.8.2
The test consisted of 4 processes running `dd` that wrote in parallel
50GB of data (Silesia corpus) to the 4 NVMe disks separately. We captured
disk write throughput, CPU utilization and compression ratio:
+---------------------------+---------+---------+---------+---------+
| | QAT-L9 | ZSTD-L3 | ZLIB-L3 | LZO-L1 |
+---------------------------+---------+---------+---------+---------+
| Disk Write TPUT (GiB/s) | 6.5 | 5.2 | 2.2 | 6.5 |
+---------------------------+---------+---------+---------+---------+
| CPU utils %age @208 cores | 4.56% | 15.67% | 12.79% | 19.85% |
+---------------------------+---------+---------+---------+---------+
| Compression Ratio | 34% | 35% | 37% | 58% |
+---------------------------+---------+---------+---------+---------+
From the results we see that BTRFS with QAT configured for zlib-deflate Level 9
provides the best throughput with less CPU utilization and better compression
ratio compared with software zstd-l3, zlib-l3 and lzo.
Limitations:
* The implementation is synchronous, even if acomp is an asynchronous API.
* The implementation tries always to use an acomp tfm even if only
zlib-deflate-scomp is present. This ignores the compression levels
configuration for zlib.
* There is no way to configure a compression level for acomp(zlib-deflate).
This is hardcoded in the acomp algorithm implementation/provider.
[1] https://lore.kernel.org/all/1467083180-111750-1-git-send-email-weigang.li@intel.com/
[2] https://lore.kernel.org/all/ZO8ULhlJSrJ0Mcsx@gondor.apana.org.au/
Giovanni Cabiddu (5):
Revert "crypto: testmgr - Remove zlib-deflate"
Revert "crypto: deflate - Remove zlib-deflate"
Revert "crypto: qat - Remove zlib-deflate"
Revert "crypto: qat - remove unused macros in qat_comp_alg.c"
crypto: qat - change compressor settings for QAT GEN4
Weigang Li (1):
btrfs: zlib: add support for zlib-deflate through acomp
crypto/deflate.c | 61 +++--
crypto/testmgr.c | 10 +
crypto/testmgr.h | 75 ++++++
.../crypto/intel/qat/qat_common/adf_gen4_dc.c | 4 +-
.../intel/qat/qat_common/qat_comp_algs.c | 138 ++++++++++-
fs/btrfs/zlib.c | 216 ++++++++++++++++++
6 files changed, 484 insertions(+), 20 deletions(-)
base-commit: ed265f7fd9a635d77c8022fc6d9a1b735dd4dfd7
--
2.44.0
next reply other threads:[~2024-04-26 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:54 Giovanni Cabiddu [this message]
2024-04-26 10:54 ` [RFC PATCH 1/6] Revert "crypto: testmgr - Remove zlib-deflate" Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 2/6] Revert "crypto: deflate " Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 3/6] Revert "crypto: qat " Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 4/6] Revert "crypto: qat - remove unused macros in qat_comp_alg.c" Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 5/6] crypto: qat - change compressor settings for QAT GEN4 Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 6/6] btrfs: zlib: add support for zlib-deflate through acomp Giovanni Cabiddu
2024-04-29 13:56 ` Josef Bacik
2024-04-29 15:21 ` Cabiddu, Giovanni
2024-04-29 15:44 ` David Sterba
2024-05-03 10:04 ` Herbert Xu
2024-04-29 15:41 ` David Sterba
2024-04-29 15:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426110941.5456-1-giovanni.cabiddu@intel.com \
--to=giovanni.cabiddu@intel.com \
--cc=brian.will@intel.com \
--cc=clm@fb.com \
--cc=cyan@meta.com \
--cc=dsterba@suse.com \
--cc=embg@meta.com \
--cc=herbert@gondor.apana.org.au \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=weigang.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).