From: Nikolay Borisov <nborisov@suse.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Remove impossible condition from mergable_maps
Date: Tue, 8 Jan 2019 09:30:39 +0200 [thread overview]
Message-ID: <29983e2d-b525-5b9f-0f37-eb06614cc454@suse.com> (raw)
In-Reply-To: <20190107191019.GD23615@twin.jikos.cz>
On 7.01.19 г. 21:10 ч., David Sterba wrote:
> On Tue, Dec 18, 2018 at 03:10:02PM +0200, Nikolay Borisov wrote:
>> We can never have extents marked as EXTENT_MAP_DELALLOC since this
>> value is only ever used by btrfs_get_extent_fiemap. In this case the
>> extent map is created by btrfs_get_extent_fiemap and is never really
>> published, this flag is used to return the corresponding userspace one.
>> Considering this, it's pointless having a check for EXTENT_MAP_DELALLOC
>> in mergable_maps. Just remove it.
>
> An assert would be good and a comment at EXTENT_MAP_DELALLOC definition
> repeating what's in the changelog. Otherwise ok.
Do we really need the assert though, it's plainly obvious
EXTENT_MAP_DELALLOC is only set in a single function?
>
next prev parent reply other threads:[~2019-01-08 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 13:10 [PATCH] btrfs: Remove impossible condition from mergable_maps Nikolay Borisov
2019-01-07 19:10 ` David Sterba
2019-01-08 7:30 ` Nikolay Borisov [this message]
2019-01-08 7:47 ` Qu Wenruo
2019-01-08 14:28 ` David Sterba
2019-01-08 14:53 ` [PATCH v2] " Nikolay Borisov
2019-01-09 14:00 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29983e2d-b525-5b9f-0f37-eb06614cc454@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).