From: Nikolay Borisov <nborisov@suse.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 5/5] btrfs: trivial, fix c coding style
Date: Fri, 8 Feb 2019 09:09:07 +0200 [thread overview]
Message-ID: <4282b9c9-5596-e51f-1005-f728a2f4aa01@suse.com> (raw)
In-Reply-To: <1549609355-11053-6-git-send-email-anand.jain@oracle.com>
On 8.02.19 г. 9:02 ч., Anand Jain wrote:
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/props.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/fs/btrfs/props.c b/fs/btrfs/props.c
> index 77a03076b18e..3c15f19bfd2f 100644
> --- a/fs/btrfs/props.c
> +++ b/fs/btrfs/props.c
> @@ -70,8 +70,8 @@ int btrfs_set_prop(struct btrfs_trans_handle *trans, struct inode *inode,
> return -EINVAL;
>
> if (value_len == 0) {
> - ret = btrfs_setxattr(trans, inode, handler->xattr_name,
> - NULL, 0, flags);
> + ret = btrfs_setxattr(trans, inode, handler->xattr_name, NULL, 0,
> + flags);
> if (ret)
> return ret;
>
> @@ -101,12 +101,10 @@ int btrfs_set_prop(struct btrfs_trans_handle *trans, struct inode *inode,
> }
>
> static int iterate_object_props(struct btrfs_root *root,
> - struct btrfs_path *path,
> - u64 objectid,
> + struct btrfs_path *path, u64 objectid,
> void (*iterator)(void *,
> const struct prop_handler *,
> - const char *,
> - size_t),
> + const char *, size_t),
> void *ctx)
> {
> int ret;
> @@ -211,10 +209,8 @@ static int iterate_object_props(struct btrfs_root *root,
> return ret;
> }
>
> -static void inode_prop_iterator(void *ctx,
> - const struct prop_handler *handler,
> - const char *value,
> - size_t len)
> +static void inode_prop_iterator(void *ctx, const struct prop_handler *handler,
> + const char *value, size_t len)
> {
> struct inode *inode = ctx;
> struct btrfs_root *root = BTRFS_I(inode)->root;
>
next prev parent reply other threads:[~2019-02-08 7:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 7:02 [PATCH 0/5] Misc props.c cleanups Anand Jain
2019-02-08 7:02 ` [PATCH 1/5] btrfs: fix comment its device list mutex not volume lock Anand Jain
2019-02-08 7:07 ` Nikolay Borisov
2019-02-08 7:16 ` Anand Jain
2019-02-08 7:19 ` Nikolay Borisov
2019-02-08 7:39 ` [PATCH v2 " Anand Jain
2019-02-11 18:41 ` David Sterba
2019-02-08 7:02 ` [PATCH 2/5] btrfs: kill __btrfs_set_prop() Anand Jain
2019-02-08 7:02 ` [PATCH 3/5] btrfs: reorg functions to drop forward declaration Anand Jain
2019-02-08 7:10 ` Nikolay Borisov
2019-02-11 18:43 ` David Sterba
2019-02-08 7:02 ` [PATCH 4/5] btrfs: drop redundant forward declaration in props.c Anand Jain
2019-02-08 7:09 ` Nikolay Borisov
2019-02-08 7:02 ` [PATCH 5/5] btrfs: trivial, fix c coding style Anand Jain
2019-02-08 7:09 ` Nikolay Borisov [this message]
2019-02-08 7:15 ` [PATCH 0/5] Misc props.c cleanups Nikolay Borisov
2019-02-08 7:31 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4282b9c9-5596-e51f-1005-f728a2f4aa01@suse.com \
--to=nborisov@suse.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).