From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 4/4] btrfs: relocation: Work around dead relocation stage loop
Date: Thu, 13 Feb 2020 15:08:18 -0500 [thread overview]
Message-ID: <75628279-595e-2ab7-b808-18ce0251f5b0@toxicpanda.com> (raw)
In-Reply-To: <20200211053729.20807-5-wqu@suse.com>
On 2/11/20 12:37 AM, Qu Wenruo wrote:
> There are some reports of dead relocation stage loop, where dmesg is
> flooded by "Found X extents".
>
> The root cause of it is still uncertain, but we can work around such bug
> by checking cancelling request so user can at least cancel such dead
> loop.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
Why? It'll get picked up by one of the other cancel checks right? I'd rather
know why things are going wrong than put something in for a just in case
scenario, especially since the other cancel points actually make sense and will
accomplish the same goal. Thanks,
Josef
next prev parent reply other threads:[~2020-02-13 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 5:37 [PATCH v2 0/4] btrfs: Make balance cancelling response faster Qu Wenruo
2020-02-11 5:37 ` [PATCH v2 1/4] btrfs: relocation: Introduce error injection points for cancelling balance Qu Wenruo
2020-02-13 20:00 ` Josef Bacik
2020-02-11 5:37 ` [PATCH v2 2/4] btrfs: relocation: Check cancel request after each data page read Qu Wenruo
2020-02-13 20:03 ` Josef Bacik
2020-02-14 17:10 ` David Sterba
2020-02-11 5:37 ` [PATCH v2 3/4] btrfs: relocation: Check cancel request after each extent found Qu Wenruo
2020-02-13 20:05 ` Josef Bacik
2020-02-11 5:37 ` [PATCH v2 4/4] btrfs: relocation: Work around dead relocation stage loop Qu Wenruo
2020-02-13 20:08 ` Josef Bacik [this message]
2020-02-14 0:33 ` Qu Wenruo
2020-02-14 17:12 ` [PATCH v2 0/4] btrfs: Make balance cancelling response faster David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75628279-595e-2ab7-b808-18ce0251f5b0@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).