From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Johannes Thumshirn <jthumshirn@suse.de>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Cc: felix@feldspaten.org
Subject: Re: [PATCH v2 0/3] btrfs: Introduce new incompat feature BG_TREE to hugely reduce mount time
Date: Tue, 8 Oct 2019 17:26:06 +0800 [thread overview]
Message-ID: <80fafbd5-b459-26de-6ebb-98eeb41f2064@gmx.com> (raw)
In-Reply-To: <c47049af-d034-0228-c61c-65187d07e6b4@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 2660 bytes --]
On 2019/10/8 下午5:14, Johannes Thumshirn wrote:
>> [[Benchmark]]
>> Since I have upgraded my rig to all NVME storage, there is no HDD
>> test result.
>>
>> Physical device: NVMe SSD
>> VM device: VirtIO block device, backup by sparse file
>> Nodesize: 4K (to bump up tree height)
>> Extent data size: 4M
>> Fs size used: 1T
>>
>> All file extents on disk is in 4M size, preallocated to reduce space usage
>> (as the VM uses loopback block device backed by sparse file)
>
> Do you have a some additional details about the test setup? I tried to
> do the same (testing) for a bug Felix (added to Cc) reported to my at
> the ALPSS Conference and I couldn't reproduce the issue.
>
> My testing was a 100TB sparse file passed into a VM and running this
> script to touch all blockgroups:
Here is my test scripts:
---
#!/bin/bash
dev="/dev/vdb"
mnt="/mnt/btrfs"
nr_subv=16
nr_extents=16384
extent_size=$((4 * 1024 * 1024)) # 4M
_fail()
{
echo "!!! FAILED: $@ !!!"
exit 1
}
fill_one_subv()
{
path=$1
if [ -z $path ]; then
_fail "wrong parameter for fill_one_subv"
fi
btrfs subv create $path || _fail "create subv"
for i in $(seq 0 $((nr_extents - 1))); do
fallocate -o $((i * $extent_size)) -l $extent_size
$path/file || _fail "fallocate"
done
}
declare -a pids
umount $mnt &> /dev/null
umount $dev &> /dev/null
#~/btrfs-progs/mkfs.btrfs -f -n 4k $dev -O bg-tree
mkfs.btrfs -f -n 4k $dev
mount $dev $mnt -o nospace_cache
for i in $(seq 1 $nr_subv); do
fill_one_subv $mnt/subv_${i} &
pids[$i]=$!
done
for i in $(seq 1 $nr_subv); do
wait ${pids[$i]}
done
sync
umount $dev
---
>
> #!/bin/sh
>
> FILE=/mnt/test
>
> add_dirty_bg() {
> off="$1"
> len="$2"
> touch $FILE
> xfs_io -c "falloc $off $len" $FILE
> rm $FILE
> }
>
> mkfs.btrfs /dev/vda
> mount /dev/vda /mnt
>
> for ((i = 1; i < 100000; i++)); do
> add_dirty_bg $i"G" "1G"
> done
This wont really build a good enough extent tree layout.
1G fallocate will only cause 8 128M file extents, thus 8 EXTENT_ITEMs.
Thus a leaf (16K by default) can still contain a lot of BLOCK_GROUPS all
together.
To build a case to really show the problem, you'll need a lot of
EXTENT_ITEM/METADATA_ITEMS to fill the gaps between BLOCK_GROUPS.
My test scripts did that, but may still not represent the real world, as
real world can cause even smaller extents due to snapshots.
Thanks,
Qu
>
> umount /mnt
>
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-08 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 4:49 [PATCH v2 0/3] btrfs: Introduce new incompat feature BG_TREE to hugely reduce mount time Qu Wenruo
2019-10-08 4:49 ` [PATCH v2 1/3] btrfs: block-group: Refactor btrfs_read_block_groups() Qu Wenruo
2019-10-08 9:08 ` Johannes Thumshirn
2019-10-09 12:08 ` Anand Jain
2019-10-09 12:14 ` Qu WenRuo
2019-10-09 13:07 ` [PATCH " Qu Wenruo
2019-10-09 14:25 ` Filipe Manana
2019-10-08 4:49 ` [PATCH v2 2/3] btrfs: disk-io: Remove unnecessary check before freeing chunk root Qu Wenruo
2019-10-08 8:30 ` Johannes Thumshirn
2019-10-10 2:00 ` Anand Jain
2019-10-10 2:21 ` Qu Wenruo
2019-10-08 4:49 ` [PATCH v2 3/3] btrfs: Introduce new incompat feature, BG_TREE, to speed up mount time Qu Wenruo
2019-10-08 9:09 ` Johannes Thumshirn
2019-10-08 9:14 ` [PATCH v2 0/3] btrfs: Introduce new incompat feature BG_TREE to hugely reduce " Johannes Thumshirn
2019-10-08 9:26 ` Qu Wenruo [this message]
2019-10-08 9:47 ` Johannes Thumshirn
[not found] ` <b4821d86-eeb9-f21c-66aa-480df2d3a13d@feldspaten.org>
2019-10-09 7:43 ` Qu Wenruo
2019-10-09 8:08 ` Felix Niederwanger
2019-10-09 11:00 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fafbd5-b459-26de-6ebb-98eeb41f2064@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=felix@feldspaten.org \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).