From: Josef Bacik <josef@toxicpanda.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 01/13] btrfs: Document modified paramater of add_extent_mapping
Date: Tue, 19 Jan 2021 16:27:25 -0500 [thread overview]
Message-ID: <8a5502f3-be55-897a-c987-f1ec57efedc8@toxicpanda.com> (raw)
In-Reply-To: <20210119122649.187778-2-nborisov@suse.com>
On 1/19/21 7:26 AM, Nikolay Borisov wrote:
> Fixes fs/btrfs/extent_map.c:399: warning: Function parameter or member
> 'modified' not described in 'add_extent_mapping'
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/extent_map.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
> index bd6229fb2b6f..aa1ff6f2ade9 100644
> --- a/fs/btrfs/extent_map.c
> +++ b/fs/btrfs/extent_map.c
> @@ -388,6 +388,8 @@ static void extent_map_device_clear_bits(struct extent_map *em, unsigned bits)
> * add_extent_mapping - add new extent map to the extent tree
> * @tree: tree to insert new map in
> * @em: map to insert
> + * @modified: bool indicating whether the given @em should be added to the
> + * modified list, which indicates the extent needs to be logged
> *
> * Insert @em into @tree or perform a simple forward/backward merge with
> * existing mappings. The extent_map struct passed in will be inserted
>
You can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
to the series once you fix up those two spelling mistakes. Thanks,
Josef
next prev parent reply other threads:[~2021-01-19 21:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 12:26 [PATCH 00/13] Make btrfs W=1 clean Nikolay Borisov
2021-01-19 12:26 ` [PATCH 01/13] btrfs: Document modified paramater of add_extent_mapping Nikolay Borisov
2021-01-19 21:25 ` Josef Bacik
2021-01-19 21:27 ` Josef Bacik [this message]
2021-01-19 12:26 ` [PATCH 02/13] btrfs: Fix parameter description of btrfs_add_extent_mapping Nikolay Borisov
2021-01-19 12:26 ` [PATCH 03/13] btrfs: Fix function description format Nikolay Borisov
2021-01-19 22:43 ` David Sterba
2021-01-19 12:26 ` [PATCH 04/13] btrfs: Fix paramter description in delayed-ref.c functions Nikolay Borisov
2021-01-19 21:26 ` Josef Bacik
2021-01-19 12:26 ` [PATCH 05/13] btrfs: Improve parameter description for __btrfs_write_out_cache Nikolay Borisov
2021-01-19 12:26 ` [PATCH 06/13] btrfs: Document now parameter of peek_discard_list Nikolay Borisov
2021-01-19 22:46 ` David Sterba
2021-01-19 12:26 ` [PATCH 07/13] btrfs: Document fs_info in btrfs_rmap_block Nikolay Borisov
2021-01-19 22:47 ` David Sterba
2021-01-19 12:26 ` [PATCH 08/13] btrfs: Fix description format of fs_info parameter of btrfs_wait_on_delayed_iputs Nikolay Borisov
2021-01-19 12:26 ` [PATCH 09/13] btrfs: Document btrfs_check_shared parameters Nikolay Borisov
2021-01-19 12:26 ` [PATCH 10/13] btrfs: Fix parameter description of btrfs_inode_rsv_release/btrfs_delalloc_release_space Nikolay Borisov
2021-01-19 12:26 ` [PATCH 11/13] btrfs: Fix parameter description in space-info.c Nikolay Borisov
2021-01-19 12:26 ` [PATCH 12/13] btrfs: Fix parameter description for functions in extent_io.c Nikolay Borisov
2021-01-19 12:26 ` [PATCH 13/13] lib/zstd: Convert constants to defines Nikolay Borisov
2021-01-19 22:39 ` [PATCH 00/13] Make btrfs W=1 clean David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a5502f3-be55-897a-c987-f1ec57efedc8@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).