From: Stefan Roesch <shr@fb.com>
To: fdmanana@gmail.com
Cc: kernel-team@fb.com, io-uring@vger.kernel.org,
linux-btrfs@vger.kernel.org, axboe@kernel.dk,
josef@toxicpanda.com
Subject: Re: [PATCH v2 12/12] btrfs: enable nowait async buffered writes
Date: Thu, 8 Sep 2022 12:14:56 -0700 [thread overview]
Message-ID: <92f25d12-804e-f76a-c431-d9eca32c564b@fb.com> (raw)
In-Reply-To: <CAL3q7H7dM3tdbnLReyrX1Vm=43NdjTPXmRrhJF7nO=Uy3fyKDA@mail.gmail.com>
On 9/8/22 3:14 AM, Filipe Manana wrote:
> On Thu, Sep 8, 2022 at 1:29 AM Stefan Roesch <shr@fb.com> wrote:
>>
>> Enable nowait async buffered writes in btrfs_do_write_iter() and
>> btrfs_file_open().
>
> This is too terse, see below.
>
>>
>> Signed-off-by: Stefan Roesch <shr@fb.com>
>> ---
>> fs/btrfs/file.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
>> index fd42ba9de7a7..887497fd524f 100644
>> --- a/fs/btrfs/file.c
>> +++ b/fs/btrfs/file.c
>> @@ -2107,13 +2107,13 @@ ssize_t btrfs_do_write_iter(struct kiocb *iocb, struct iov_iter *from,
>> if (BTRFS_FS_ERROR(inode->root->fs_info))
>> return -EROFS;
>>
>> - if ((iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT))
>> - return -EOPNOTSUPP;
>> -
>> if (sync)
>> atomic_inc(&inode->sync_writers);
>>
>> if (encoded) {
>> + if (iocb->ki_flags & IOCB_NOWAIT)
>> + return -EOPNOTSUPP;
>
> The changelog should provide some rationale about why encoded writes
> are not supported.
>
> Thanks.
I added an explanation why encoded writes are not yet supported.
>
>> +
>> num_written = btrfs_encoded_write(iocb, from, encoded);
>> num_sync = encoded->len;
>> } else if (iocb->ki_flags & IOCB_DIRECT) {
>> @@ -3755,7 +3755,7 @@ static int btrfs_file_open(struct inode *inode, struct file *filp)
>> {
>> int ret;
>>
>> - filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC;
>> + filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC;
>>
>> ret = fsverity_file_open(inode, filp);
>> if (ret)
>> --
>> 2.30.2
>>
>
>
next prev parent reply other threads:[~2022-09-08 19:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 0:26 [PATCH v2 00/12] io-uring/btrfs: support async buffered writes Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 01/12] mm: export balance_dirty_pages_ratelimited_flags() Stefan Roesch
2022-09-08 10:18 ` Filipe Manana
2022-09-08 0:26 ` [PATCH v2 02/12] btrfs: implement a nowait option for tree searches Stefan Roesch
2022-09-08 13:19 ` Josef Bacik
2022-09-08 18:05 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 03/12] btrfs: make can_nocow_extent nowait compatible Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 04/12] btrfs: add the ability to use NO_FLUSH for data reservations Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 05/12] btrfs: add btrfs_try_lock_ordered_range Stefan Roesch
2022-09-08 10:18 ` Filipe Manana
2022-09-08 18:12 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 06/12] btrfs: make btrfs_check_nocow_lock nowait compatible Stefan Roesch
2022-09-08 10:18 ` Filipe Manana
2022-09-08 18:23 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 07/12] btrfs: make prepare_pages " Stefan Roesch
2022-09-08 10:17 ` Filipe Manana
2022-09-08 18:33 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 08/12] btrfs: make lock_and_cleanup_extent_if_need " Stefan Roesch
2022-09-08 10:17 ` Filipe Manana
2022-09-08 18:38 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 09/12] btrfs: btrfs: plumb NOWAIT through the write path Stefan Roesch
2022-09-08 10:16 ` Filipe Manana
2022-09-08 18:44 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 10/12] btrfs: make balance_dirty_pages nowait compatible Stefan Roesch
2022-09-08 10:16 ` Filipe Manana
2022-09-08 18:48 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 11/12] btrfs: add assert to search functions Stefan Roesch
2022-09-08 10:15 ` Filipe Manana
2022-09-08 19:10 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 12/12] btrfs: enable nowait async buffered writes Stefan Roesch
2022-09-08 10:14 ` Filipe Manana
2022-09-08 19:14 ` Stefan Roesch [this message]
2022-09-08 10:14 ` [PATCH v2 00/12] io-uring/btrfs: support " Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f25d12-804e-f76a-c431-d9eca32c564b@fb.com \
--to=shr@fb.com \
--cc=axboe@kernel.dk \
--cc=fdmanana@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).