linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Johannes Thumshirn <jthumshirn@suse.de>, Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/8] btrfs: extent-tree: Open-code process_func in __btrfs_mod_ref
Date: Wed, 12 Dec 2018 18:07:17 +0800	[thread overview]
Message-ID: <96bd3959-822d-5289-4b84-3a5db88ac991@gmx.com> (raw)
In-Reply-To: <c8dadde8-611a-e402-6b1f-495847164028@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 692 bytes --]



On 2018/12/12 下午5:40, Johannes Thumshirn wrote:
> On 12/12/2018 08:30, Qu Wenruo wrote:
>> The process_func is never a function hook used anywhere else.
>>
> 
> Hmm this sounds odd, maybe something like:
> 
> The process_func function pointer is local to __btrfs_mod_ref() and
> points to either btrfs_inc_extent_ref() or btrfs_free_extent().

Much better, thanks for the better words!

I'll reword these commits.

Thanks,
Qu

> 
>> Open code it to make later delayed ref refactor easier, so we can
>> refactor btrfs_inc_extent_ref() and btrfs_free_extent() in different
>> patches.
> 
> Otherwise:
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-12-12 10:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  7:30 [PATCH v2 0/8] btrfs: Refactor delayed ref parameter list Qu Wenruo
2018-12-12  7:30 ` [PATCH v2 1/8] btrfs: delayed-ref: Introduce better documented delayed ref structures Qu Wenruo
2018-12-12  9:31   ` Johannes Thumshirn
2018-12-12 11:01   ` [PATCH v2.1 " Qu Wenruo
2018-12-12  7:30 ` [PATCH v2 2/8] btrfs: extent-tree: Open-code process_func in __btrfs_mod_ref Qu Wenruo
2018-12-12  9:40   ` Johannes Thumshirn
2018-12-12 10:07     ` Qu Wenruo [this message]
2018-12-12 11:01   ` [PATCH v2.1 " Qu Wenruo
2018-12-12  7:30 ` [PATCH v2 3/8] btrfs: delayed-ref: Use btrfs_ref to refactor btrfs_add_delayed_tree_ref() Qu Wenruo
2018-12-12  7:30 ` [PATCH v2 4/8] btrfs: delayed-ref: Use btrfs_ref to refactor btrfs_add_delayed_data_ref() Qu Wenruo
2018-12-12  7:30 ` [PATCH v2 5/8] btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod() Qu Wenruo
2018-12-12  7:31 ` [PATCH v2 6/8] btrfs: extent-tree: Use btrfs_ref to refactor add_pinned_bytes() Qu Wenruo
2018-12-12  7:31 ` [PATCH v2 7/8] btrfs: extent-tree: Use btrfs_ref to refactor btrfs_inc_extent_ref() Qu Wenruo
2018-12-12  7:31 ` [PATCH v2 8/8] btrfs: extent-tree: Use btrfs_ref to refactor btrfs_free_extent() Qu Wenruo
2018-12-12 12:42 ` [PATCH v2 0/8] btrfs: Refactor delayed ref parameter list David Sterba
2018-12-12 13:21   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96bd3959-822d-5289-4b84-3a5db88ac991@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).