From: Linus Torvalds <torvalds@linux-foundation.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <david@fromorbit.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Kernel Team <kernel-team@fb.com>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH RESEND x3 v9 1/9] iov_iter: add copy_struct_from_iter()
Date: Thu, 24 Jun 2021 10:52:17 -0700 [thread overview]
Message-ID: <CAHk-=whmRQWm_gVek32ekPqBi3zAKOsdK6_6Hx8nHp3H5JAMew@mail.gmail.com> (raw)
In-Reply-To: <YNQi3vgCLVs/ExiK@relinquished.localdomain>
On Wed, Jun 23, 2021 at 11:15 PM Omar Sandoval <osandov@osandov.com> wrote:
>
> On Thu, Jun 24, 2021 at 03:00:39AM +0100, Matthew Wilcox wrote:
> >
> > Does that work for O_DIRECT and the required 512-byte alignment?
>
> I suppose the kernel could pad the encoded_iov structure with zeroes to
> the next sector boundary, since zeroes are effectively noops for
> encoded_iov.
Ugh.
I really think the whole "embed the control structure in the stream"
is wrong. The alignment issue is just another sign of that.
Separating it out is the right thing to do. At least the "first iov
entry" thing did separate the control structure from the actual data.
I detest the whole "embed the two together".
Linus
next prev parent reply other threads:[~2021-06-24 17:52 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 23:51 [PATCH RESEND x3 v9 0/9] fs: interface for directly reading/writing compressed data Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 1/9] iov_iter: add copy_struct_from_iter() Omar Sandoval
2021-06-18 18:50 ` Linus Torvalds
2021-06-18 19:42 ` Al Viro
2021-06-18 19:49 ` Al Viro
2021-06-18 20:33 ` Omar Sandoval
2021-06-18 20:32 ` Omar Sandoval
2021-06-18 20:58 ` Al Viro
2021-06-18 21:10 ` Linus Torvalds
2021-06-18 21:32 ` Al Viro
2021-06-18 21:40 ` Linus Torvalds
2021-06-18 22:10 ` Omar Sandoval
2021-06-18 22:32 ` Al Viro
2021-06-19 0:43 ` Omar Sandoval
2021-06-21 18:46 ` Omar Sandoval
2021-06-21 19:33 ` Linus Torvalds
2021-06-21 20:46 ` Omar Sandoval
2021-06-21 20:53 ` Omar Sandoval
2021-06-21 20:55 ` Omar Sandoval
2021-06-22 22:06 ` Dave Chinner
2021-06-23 17:49 ` Omar Sandoval
2021-06-23 18:28 ` Linus Torvalds
2021-06-23 19:33 ` Omar Sandoval
2021-06-23 19:45 ` Al Viro
2021-06-23 20:46 ` Omar Sandoval
2021-06-23 21:39 ` Al Viro
2021-06-23 21:58 ` Omar Sandoval
2021-06-23 22:26 ` Al Viro
2021-06-24 2:00 ` Matthew Wilcox
2021-06-24 6:14 ` Omar Sandoval
2021-06-24 17:52 ` Linus Torvalds [this message]
2021-06-24 18:28 ` Omar Sandoval
2021-06-24 21:07 ` Linus Torvalds
2021-06-24 22:41 ` Martin K. Petersen
2021-06-25 3:38 ` Matthew Wilcox
2021-06-25 16:16 ` Linus Torvalds
2021-06-25 21:07 ` Omar Sandoval
2021-07-07 17:59 ` Omar Sandoval
2021-07-19 15:44 ` Josef Bacik
2021-06-24 6:41 ` Christoph Hellwig
2021-06-24 7:50 ` Omar Sandoval
2021-06-18 22:14 ` Al Viro
2021-06-17 23:51 ` [PATCH RESEND x3 v9 2/9] fs: add O_ALLOW_ENCODED open flag Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 3/9] fs: add RWF_ENCODED for reading/writing compressed data Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 4/9] btrfs: don't advance offset for compressed bios in btrfs_csum_one_bio() Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 5/9] btrfs: add ram_bytes and offset to btrfs_ordered_extent Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 6/9] btrfs: support different disk extent size for delalloc Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 7/9] btrfs: optionally extend i_size in cow_file_range_inline() Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 8/9] btrfs: implement RWF_ENCODED reads Omar Sandoval
2021-06-17 23:51 ` [PATCH RESEND x3 v9 9/9] btrfs: implement RWF_ENCODED writes Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whmRQWm_gVek32ekPqBi3zAKOsdK6_6Hx8nHp3H5JAMew@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).