From: Nikolay Borisov <nborisov@suse.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/6] Block group structure cleanups
Date: Thu, 24 Oct 2019 15:09:46 +0300 [thread overview]
Message-ID: <a67ae4cf-2cd8-7d5e-ad8f-d68c9b0f4ed1@suse.com> (raw)
In-Reply-To: <cover.1571848791.git.dsterba@suse.com>
On 23.10.19 г. 19:48 ч., David Sterba wrote:
> The block group cache structure has two embedded members that belong to
> the on-disk format but were used for the in-memory structures. It's been
> like that forever and I wonder why nobody was bothered by that. Switch
> to normal members and rename a few things on along the way.
>
> The size of block_group_cache is down from 528 to 504 so it should not
> fit better to slab pages. Further shrinkage is possible.
>
> David Sterba (6):
> btrfs: move block_group_item::used to block group
> btrfs: move block_group_item::flags to block group
> btrfs: remove embedded block_group_cache::item
> btrfs: rename block_group_item on-stack accessors to follow naming
> btrfs: rename extent buffer block group item accessors
> btrfs: add dedicated members for start and length of a block group
>
> fs/btrfs/block-group.c | 191 +++++++++++++------------
> fs/btrfs/block-group.h | 5 +-
> fs/btrfs/ctree.h | 12 +-
> fs/btrfs/extent-tree.c | 31 ++--
> fs/btrfs/free-space-cache.c | 39 +++--
> fs/btrfs/free-space-tree.c | 83 ++++++-----
> fs/btrfs/ioctl.c | 5 +-
> fs/btrfs/print-tree.c | 6 +-
> fs/btrfs/reada.c | 4 +-
> fs/btrfs/relocation.c | 18 +--
> fs/btrfs/scrub.c | 10 +-
> fs/btrfs/space-info.c | 3 +-
> fs/btrfs/sysfs.c | 4 +-
> fs/btrfs/tests/btrfs-tests.c | 5 +-
> fs/btrfs/tests/free-space-tree-tests.c | 75 +++++-----
> fs/btrfs/tree-checker.c | 10 +-
> fs/btrfs/volumes.c | 19 ++-
> include/trace/events/btrfs.h | 21 ++-
> 18 files changed, 264 insertions(+), 277 deletions(-)
>
I quitte like the series, especially the last patch which puts sanity
into how we refer to bg start/size.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
prev parent reply other threads:[~2019-10-24 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:48 [PATCH 0/6] Block group structure cleanups David Sterba
2019-10-23 16:48 ` [PATCH 1/6] btrfs: move block_group_item::used to block group David Sterba
2019-10-24 8:22 ` Johannes Thumshirn
2019-10-23 16:48 ` [PATCH 2/6] btrfs: move block_group_item::flags " David Sterba
2019-10-24 8:30 ` Johannes Thumshirn
2019-10-23 16:48 ` [PATCH 3/6] btrfs: remove embedded block_group_cache::item David Sterba
2019-10-24 8:33 ` Johannes Thumshirn
2019-10-23 16:48 ` [PATCH 4/6] btrfs: rename block_group_item on-stack accessors to follow naming David Sterba
2019-10-24 8:34 ` Johannes Thumshirn
2019-10-23 16:48 ` [PATCH 5/6] btrfs: rename extent buffer block group item accessors David Sterba
2019-10-24 8:35 ` Johannes Thumshirn
2019-10-23 16:48 ` [PATCH 6/6] btrfs: add dedicated members for start and length of a block group David Sterba
2019-10-24 9:15 ` Johannes Thumshirn
2019-10-24 12:09 ` Nikolay Borisov
2019-10-24 1:48 ` [PATCH 0/6] Block group structure cleanups Qu Wenruo
2019-10-24 12:09 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67ae4cf-2cd8-7d5e-ad8f-d68c9b0f4ed1@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).