From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Open code key_search
Date: Wed, 27 May 2020 15:35:58 +0300 [thread overview]
Message-ID: <d8b4ec4c-2741-f677-2667-61a249d37fc4@suse.com> (raw)
In-Reply-To: <SN4PR0401MB3598A1745DF9F32092AFD2269BB10@SN4PR0401MB3598.namprd04.prod.outlook.com>
On 27.05.20 г. 15:25 ч., Johannes Thumshirn wrote:
> On 27/05/2020 12:11, Nikolay Borisov wrote:
>
> Looks good,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
> One nit though:
>
>> + ret = btrfs_bin_search(b, key, &slot);
>> + prev_cmp = ret;
>
> I actually find:
> ret = prev_cmp = brtfs_bin_search(b, key, &slot);
>
> a bit more readable in this case.
>
True, AFAIK David is not a fan of multiple assignments on the same line ;)
next prev parent reply other threads:[~2020-05-27 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:10 [PATCH] btrfs: Open code key_search Nikolay Borisov
2020-05-27 12:25 ` Johannes Thumshirn
2020-05-27 12:35 ` Nikolay Borisov [this message]
2020-05-27 12:39 ` Johannes Thumshirn
2020-05-27 13:04 ` David Sterba
2020-05-27 13:54 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b4ec4c-2741-f677-2667-61a249d37fc4@suse.com \
--to=nborisov@suse.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).