From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: kernel@pengutronix.de, Dan Murphy <dmurphy@ti.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [net-rfc 12/12] can: m_can: Remove unused clock function from the framework
Date: Mon, 19 Oct 2020 17:42:33 +0200 [thread overview]
Message-ID: <20201019154233.1262589-13-mkl@pengutronix.de> (raw)
In-Reply-To: <20201019154233.1262589-1-mkl@pengutronix.de>
From: Dan Murphy <dmurphy@ti.com>
Remove the unused clock function from the framework as the clock discovery,
initilaization and management are all within the registrars code.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Link: http://lore.kernel.org/r/20200131183433.11041-4-dmurphy@ti.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/m_can.c | 16 ----------------
drivers/net/can/m_can/m_can.h | 3 ---
2 files changed, 19 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 90ee636dd382..e1d8d1c8ab7d 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1747,22 +1747,6 @@ void m_can_init_ram(struct m_can_classdev *cdev)
}
EXPORT_SYMBOL_GPL(m_can_init_ram);
-int m_can_class_get_clocks(struct m_can_classdev *m_can_dev)
-{
- int ret = 0;
-
- m_can_dev->hclk = devm_clk_get(m_can_dev->dev, "hclk");
- m_can_dev->cclk = devm_clk_get(m_can_dev->dev, "cclk");
-
- if (IS_ERR(m_can_dev->cclk)) {
- dev_err(m_can_dev->dev, "no clock found\n");
- ret = -ENODEV;
- }
-
- return ret;
-}
-EXPORT_SYMBOL_GPL(m_can_class_get_clocks);
-
struct m_can_classdev *m_can_class_allocate_dev(struct device *dev)
{
struct m_can_classdev *class_dev = NULL;
diff --git a/drivers/net/can/m_can/m_can.h b/drivers/net/can/m_can/m_can.h
index b2699a7c9997..03e97872675d 100644
--- a/drivers/net/can/m_can/m_can.h
+++ b/drivers/net/can/m_can/m_can.h
@@ -74,8 +74,6 @@ struct m_can_classdev {
struct napi_struct napi;
struct net_device *net;
struct device *dev;
- struct clk *hclk;
- struct clk *cclk;
struct workqueue_struct *tx_wq;
struct work_struct tx_work;
@@ -102,7 +100,6 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev);
void m_can_class_free_dev(struct net_device *net);
int m_can_class_register(struct m_can_classdev *cdev);
void m_can_class_unregister(struct m_can_classdev *cdev);
-int m_can_class_get_clocks(struct m_can_classdev *cdev);
void m_can_init_ram(struct m_can_classdev *priv);
void m_can_config_endisable(struct m_can_classdev *priv, bool enable);
--
2.28.0
prev parent reply other threads:[~2020-10-19 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:42 [RFC]: can 2020-10-19: m_can/tcan4x5x Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 01/12] can: m_can: remove double clearing of clock stop request bit Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 02/12] can: m_can: m_can_handle_state_change(): fix state change Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 03/12] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 04/12] can: tcan4x5x: tcan4x5x_clear_interrupts(): remove redundant return statement Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 05/12] can: tcan4x5x: Rename parse_config() function Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 06/12] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init() Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 07/12] can: m_can: m_can_class_free_dev(): introduce new function Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 08/12] can: m_can: Fix freeing of can device from peripherials Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 09/12] can: m_can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 10/12] can: tcan4x5x: Move clock init to TCAN driver Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 11/12] can: m_can_platform: Move clock discovery and init to platform Marc Kleine-Budde
2020-10-19 15:42 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019154233.1262589-13-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dmurphy@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).