Re: [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo()

From: Aswath Govindraju <a-govindraju@ti.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Lokesh Vutla <lokeshvutla@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Matt Kline <matt@bitbashing.io>,
	<linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo()
Date: Mon, 20 Sep 2021 18:06:28 +0530	[thread overview]
Message-ID: <2d069fd4-fc98-f1ce-7f26-c3e2569e7efa@ti.com> (raw)
In-Reply-To: <20210916112151.26494-1-a-govindraju@ti.com>

Hi all,

On 16/09/21 4:51 pm, Aswath Govindraju wrote:
> The write into fifo must be performed with an offset from the message ram
> base address. Therefore, fix the base address to mram_base.
> 
> Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---

This change along with some more fixes are squashed and posted in,

https://patchwork.kernel.org/project/netdevbpf/patch/20210920123344.2320-1-a-govindraju@ti.com/

Thanks,
Aswath

>  drivers/net/can/m_can/m_can_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> index 308d4f2fff00..08eac03ebf2a 100644
> --- a/drivers/net/can/m_can/m_can_platform.c
> +++ b/drivers/net/can/m_can/m_can_platform.c
> @@ -52,7 +52,7 @@ static int iomap_write_fifo(struct m_can_classdev *cdev, int offset,
>  {
>  	struct m_can_plat_priv *priv = cdev_to_priv(cdev);
>  
> -	iowrite32_rep(priv->base + offset, val, val_count);
> +	iowrite32_rep(priv->mram_base + offset, val, val_count);
>  
>  	return 0;
>  }
> 