From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: linux-can <linux-can@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v1 3/5] can: netlink: move '=' operators back to previous line (checkpatch fix)
Date: Tue, 23 Feb 2021 20:49:55 +0100 [thread overview]
Message-ID: <87im6id0o3.fsf@hardanger.blackshift.org> (raw)
In-Reply-To: <20210223162852.218041-4-mailhol.vincent@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 2075 bytes --]
On 24.02.2021 01:28:50, Vincent Mailhol wrote:
[...]
> --- a/drivers/net/can/dev/netlink.c
> +++ b/drivers/net/can/dev/netlink.c
> @@ -8,20 +8,18 @@
> #include <net/rtnetlink.h>
>
> static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
> - [IFLA_CAN_STATE] = { .type = NLA_U32 },
> - [IFLA_CAN_CTRLMODE] = { .len = sizeof(struct can_ctrlmode) },
> - [IFLA_CAN_RESTART_MS] = { .type = NLA_U32 },
> - [IFLA_CAN_RESTART] = { .type = NLA_U32 },
> - [IFLA_CAN_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> - [IFLA_CAN_BITTIMING_CONST]
> - = { .len = sizeof(struct can_bittiming_const) },
> - [IFLA_CAN_CLOCK] = { .len = sizeof(struct can_clock) },
> - [IFLA_CAN_BERR_COUNTER] = { .len = sizeof(struct can_berr_counter) },
> - [IFLA_CAN_DATA_BITTIMING]
> - = { .len = sizeof(struct can_bittiming) },
> - [IFLA_CAN_DATA_BITTIMING_CONST]
> - = { .len = sizeof(struct can_bittiming_const) },
> - [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
> + [IFLA_CAN_STATE] = { .type = NLA_U32 },
> + [IFLA_CAN_CTRLMODE] = { .len = sizeof(struct can_ctrlmode) },
> + [IFLA_CAN_RESTART_MS] = { .type = NLA_U32 },
> + [IFLA_CAN_RESTART] = { .type = NLA_U32 },
> + [IFLA_CAN_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> + [IFLA_CAN_BITTIMING_CONST] = { .len = sizeof(struct can_bittiming_const) },
> + [IFLA_CAN_CLOCK] = { .len = sizeof(struct can_clock) },
> + [IFLA_CAN_BERR_COUNTER] = { .len = sizeof(struct can_berr_counter) },
> + [IFLA_CAN_DATA_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> + [IFLA_CAN_DATA_BITTIMING_CONST] = { .len = sizeof(struct can_bittiming_const) },
> + [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
> + [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
You doubled the last entry by mistake.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-23 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 16:28 [PATCH v1 0/5] Introducing new CAN FD bittiming parameters: Transmission Delay Compensation (TDC) Vincent Mailhol
2021-02-23 16:28 ` [PATCH v1 1/5] can: add new CAN FD bittiming parameters: Transmitter " Vincent Mailhol
2021-02-23 16:28 ` [PATCH v1 2/5] can: dev: reorder struct can_priv members for better packing Vincent Mailhol
2021-02-23 16:28 ` [PATCH v1 3/5] can: netlink: move '=' operators back to previous line (checkpatch fix) Vincent Mailhol
2021-02-23 19:47 ` Marc Kleine-Budde
2021-02-24 0:05 ` Vincent MAILHOL
2021-02-23 19:49 ` Marc Kleine-Budde [this message]
2021-02-24 0:10 ` Vincent MAILHOL
2021-02-23 16:28 ` [PATCH v1 4/5] can: add netlink interface for CAN-FD Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-02-23 19:52 ` Marc Kleine-Budde
2021-02-23 16:28 ` [PATCH v1 5/5] can: bittiming: add calculation for CAN FD " Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im6id0o3.fsf@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).