linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yasushi SHOJI <yasushi.shoji@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: linux-can@vger.kernel.org, mkl@pengutronix.de,
	Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb
Date: Sun, 25 Jul 2021 19:44:43 +0900	[thread overview]
Message-ID: <CAELBRWJQ+QN6+D0M-61Fz818fm7Q-pP4LW=-KUe+nsyFFSXXPg@mail.gmail.com> (raw)
In-Reply-To: <20210725111242.2d9a819f@gmail.com>

Hi Pavel,

On Sun, Jul 25, 2021 at 5:12 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
> Can You try the following patch?
>
> diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
> index a45865bd7254..a1a154c08b7f 100644
> --- a/drivers/net/can/usb/mcba_usb.c
> +++ b/drivers/net/can/usb/mcba_usb.c
> @@ -653,6 +653,8 @@ static int mcba_usb_start(struct mcba_priv *priv)
>                         break;
>                 }
>
> +               urb->transfer_dma = buf_dma;
> +
>                 usb_fill_bulk_urb(urb, priv->udev,
>                                   usb_rcvbulkpipe(priv->udev, MCBA_USB_EP_IN),
>                                   buf, MCBA_USB_RX_BUFF_SIZE,

Yup, this patch fixed it.  I've tested on top of v5.10.52.

Tested-by: Yasushi SHOJI <yashi@spacecubics.com>

> I am sorry for breaking your device :(

No problem.  It'd be nice if we'd test with real hardware before
merging into the stable tree, though.
Anyway, thank you for your quick fix!

Best regards,
--
               yashi

  parent reply	other threads:[~2021-07-25 10:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25  7:42 [PATCH] can: mcba_usb: fix memory leak in mcba_usb Yasushi SHOJI
2021-07-25  8:12 ` Pavel Skripkin
2021-07-25  9:42   ` Marc Kleine-Budde
2021-07-25 10:18     ` Pavel Skripkin
2021-07-25 10:36     ` [PATCH] net: can: add missing urb->transfer_dma initialization Pavel Skripkin
2021-07-25 13:27       ` Yasushi SHOJI
2021-07-25 16:30         ` Marc Kleine-Budde
2021-07-25 10:44   ` Yasushi SHOJI [this message]
2021-07-25 16:27     ` [PATCH] can: mcba_usb: fix memory leak in mcba_usb Marc Kleine-Budde
2021-07-25 16:35       ` Yasushi SHOJI
2021-07-26  9:31         ` Marc Kleine-Budde
2021-07-26  9:34           ` Marc Kleine-Budde
2021-07-26 10:43             ` Yasushi SHOJI
2021-07-26 10:42           ` Yasushi SHOJI
2021-07-26 11:17             ` Marc Kleine-Budde
2021-07-27  2:19               ` Yasushi SHOJI
  -- strict thread matches above, loose matches on Subject: below --
2021-06-09 21:58 Pavel Skripkin
2021-06-15  7:33 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAELBRWJQ+QN6+D0M-61Fz818fm7Q-pP4LW=-KUe+nsyFFSXXPg@mail.gmail.com' \
    --to=yasushi.shoji@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=paskripkin@gmail.com \
    --cc=yashi@spacecubics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).