From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B655C433EF for ; Wed, 18 May 2022 16:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239782AbiERQBv (ORCPT ); Wed, 18 May 2022 12:01:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239718AbiERQBu (ORCPT ); Wed, 18 May 2022 12:01:50 -0400 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3101F149AA0; Wed, 18 May 2022 09:01:49 -0700 (PDT) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-2ec42eae76bso29306507b3.10; Wed, 18 May 2022 09:01:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=exZDVy0fXYEUjJOxnnEOEY7L5w0sPe9Rc4hUPUbdQGk=; b=sa9JJ91Drnl/h/V6aFyJaghUpVrkHHilaVs8lqLifbeZtMuIRau+S0JLzQd8qcLFsQ WA/7/M836dhgu8bFIb9YIuLVHONKkay0njTTWDdSiiMs0cnA2hRqev3tn0NGUXLam2aM gB/TtHvq+6ch2PorgvIKvTu5eVgn2PLrcCGveDbc1GiGl4EKeJ32rao0OLRN1+uh9IBG biebRNp8uQ04OH/by6sROMIrnb0GDTZK7rPoSKfEiYGdrU5Fg6GkuUmfqWd3QSoG3HSN jsR7uED6iEfRccCWpIVd1GZqAzRg2xPUGAeKPqpNbkctoCII6xbaRqIKt9XTyBiLAWm8 lzGA== X-Gm-Message-State: AOAM533cwyvfr4XiyRgaaljGjGU8N8yd5dtIButz0BhMgPisocbr6Gs8 qhXBAQ5b9mdNxD/T1/xHjB308FIyq706QzbSc1FgpZzgW8Xlig== X-Google-Smtp-Source: ABdhPJwTRLxPjlziJXAcADX0e0mcHrERe93V6DdVLqohRvtfXMxTR2hhhAnek8Ds9RpGjME0IHcem5bgFmCogVvrlAQ= X-Received: by 2002:a81:140e:0:b0:2fe:c3a3:5b19 with SMTP id 14-20020a81140e000000b002fec3a35b19mr91778ywu.392.1652889708371; Wed, 18 May 2022 09:01:48 -0700 (PDT) MIME-Version: 1.0 References: <20220517141404.578d188a.max@enpas.org> <20220517122153.4r6n6kkbdslsa2hv@pengutronix.de> <20220517143921.08458f2c.max@enpas.org> <0b505b1f-1ee4-5a2c-3bbf-6e9822f78817@hartkopp.net> <43768ff7-71f8-a6c3-18f8-28609e49eedd@hartkopp.net> <20220518132811.xfmwms2cu3bfxgrp@pengutronix.de> <3dbe135e-d13c-5c5d-e7e4-b9c13b820fb8@hartkopp.net> <20220518143613.2a7alnw6vtkw7ct2@pengutronix.de> <482fd87a-df5a-08f7-522b-898d68c3b04a@hartkopp.net> <899706c6-0aac-b039-4b67-4e509ff0930d@hartkopp.net> <20220518174803.010db67d.max@enpas.org> In-Reply-To: <20220518174803.010db67d.max@enpas.org> From: Vincent MAILHOL Date: Thu, 19 May 2022 01:01:36 +0900 Message-ID: Subject: Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c To: Max Staudt Cc: Oliver Hartkopp , Marc Kleine-Budde , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Thu. 19 May 2022 at 00:52, Max Staudt wrote: > On Thu, 19 May 2022 00:38:51 +0900 > Vincent MAILHOL wrote: > > > On Wed. 18 May 2022 at 23:59, Oliver Hartkopp > > wrote: > > > I can send a patch for this removal too. That's an easy step which > > > might get into 5.19 then. > > > > OK, go ahead. On my side, I will start to work on the other changes > > either next week or next next week, depending on my mood. > > Any wishes for the next version of can327/elmcan? The only thing I guess would be to remove the check against CAN_CTRLMODE_LISTENONLY in your xmit() function. The other things, I already commented :) > Should I wait until your changes are in? I do not think you have to wait. There are no real dependencies. You might just want to add a note after the --- scissors in the patch that there is a weak dependencies on https://lore.kernel.org/linux-can/20220514141650.1109542-5-mailhol.vincent@wanadoo.fr/ Yours sincerely, Vincent Mailhol